search

mxinden / modbus_exporter

Exporter which retrieves stats from a modbus system and exports them via HTTP for Prometheus consumption.
GNU General Public License v3.0
1 stars 0 forks source link

Get rid of more slave references #16

Closed RichiH closed 5 years ago

RichiH commented 5 years ago

Like https://github.com/RichiH/modbus_exporter/issues/1 , but through the whole codebase. target should be suitable in most cases.

mxinden commented 5 years ago 
$ grep -ri -E "slave" | grep -v vendor
modbus/modbus.go:       handler.SlaveId = subTarget

Only reference of the word is a call into the modbus library. Hence I am closing here.

RichiH commented 5 years ago

Thanks!

Sent by mobile; please excuse my brevity.

On Fri, Jun 28, 2019, 16:29 Max Inden notifications@github.com wrote:

$ grep -ri -E "slave" | grep -v vendor modbus/modbus.go: handler.SlaveId = subTarget

Only reference of the word is a call into the modbus library. Hence I am closing here.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mxinden/modbus_exporter/issues/16?email_source=notifications&email_token=AAFYII6SNW2A6UUSGKY3KJDP4YN3TA5CNFSM4HZBKLX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY2HM6I#issuecomment-506754681, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFYII5AIR52NOLZFRUWSH3P4YN3TANCNFSM4HZBKLXQ .