search

mxinden / modbus_exporter

Exporter which retrieves stats from a modbus system and exports them via HTTP for Prometheus consumption.
GNU General Public License v3.0
1 stars 0 forks source link

*: Configure modbus unit aka. sub target in prometheus.yml #21

Closed mxinden closed 5 years ago

mxinden commented 5 years ago

This pull request contains two commits:

  1. Instead of configuring the modbus unit per modbus module in the modbus.yml configuration file, with this commit the modbus unit is configured in prometheus.yml and passed to the exporter via an http parameter.

    This keeps the modbus exporter configuration file (modbus.yml) generic (containing only hardware specific module definitions) and the modbus unit (0-255) part of the information that identifies a Prometheus scrape instance.

  2. README.md: Add sequence diagram to visualize scrape sequence

//CC @RichiH @bastischubert

RichiH commented 5 years ago

Lgtm

Sent by mobile; please excuse my brevity.

On Thu, Jun 27, 2019, 16:40 Max Inden notifications@github.com wrote:

This pull request contains two commits:

1.

Instead of configuring the modbus unit per modbus module in the modbus.yml configuration file, with this commit the modbus unit is configured in prometheus.yml and passed to the exporter via an http parameter.

This keeps the modbus exporter configuration file (modbus.yml) generic (containing only hardware specific module definitions) and the modbus unit (0-255) part of the information that identifies a Prometheus scrape instance. 2.

README.md: Add sequence diagram to visualize scrape sequence

//CC @RichiH https://github.com/RichiH @bastischubert https://github.com/bastischubert

You can view, comment on, or merge this pull request online at:

https://github.com/mxinden/modbus_exporter/pull/21 Commit Summary

  • README.md: Add sequence diagram to visualize scrape sequence
  • *: Configure modbus unit aka. sub target in prometheus.yml

File Changes

Patch Links:

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mxinden/modbus_exporter/pull/21?email_source=notifications&email_token=AAFYII3KGTTBHZG5TUL75BDP4TGNLA5CNFSM4H34W3ZKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G4C75KA, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFYIIZRIWXF2A3V254UWQLP4TGNLANCNFSM4H34W3ZA .