search

mxlgv / dino

This is Dino+ A modern XMPP/Jabber client software, based on Dino
GNU General Public License v3.0
15 stars 9 forks source link

Fix Dino does not refresh expired TURN\STUN server credentials #61

Closed VadimNk closed 5 months ago

VadimNk commented 5 months ago

Add a field in Xmpp.Xep.ExternalServiceDiscovery to keep track of the expires TURN service value and use it (divided by 2) to restart periodically the external services discovery.

Without this patch, calls (actually ICE) fail to initiate after 24h of Dino uptime because of the expiry of the TURN credentials.

This happened on my setup using prosody (using the default credentials' TTL of 86400) and coturn.

VadimNk commented 5 months ago

After a 24-hour test, audio dialing is successful and the sound goes in both directions. In the original PR, after a network reconnection there was no sound from the 24 hour client.