search

mxlgv / dino

This is Dino+ A modern XMPP/Jabber client software, based on Dino
GNU General Public License v3.0
15 stars 9 forks source link

Add option for no encryption by default for new conversations #78

Open josephmturner opened 3 months ago

josephmturner commented 3 months ago

Thank you for merging https://github.com/dino/dino/pull/1414 as #20! As I mentioned in a comment on the upstream PR:

Thanks for this PR! My two cents as a user of JMP (where encryption with the SMS bridge is pointless) is that an option to select "none" as default is an important addition.

Would you be willing to add such an option to this fork?

Thank you!! This fork is working very well on the pinephone and desktop!

Joseph

josephmturner commented 3 months ago

The simplest solution might be to just do exactly what the dialog box says:

Choosing one of the encryption methods will also set it as default in the global settings.

WDYT about setting "none" to the default if the user selects in the popup dialog?

mxlgv commented 3 months ago

@josephmturner hello! Thanks for using Dino+, but I don't understand what you mean. You can disable encryption globally in the settings. Or do you mean something else?

josephmturner commented 3 months ago

Hello! Each time I start a new conversation, I am prompted to choose between OMEMO, PGP, or Unencrypted. I'd like to never be prompted and have all new conversations opened without encryption. Is that possible?

giantplaceholder commented 3 months ago

Hello! Each time I start a new conversation, I am prompted to choose between OMEMO, PGP, or Unencrypted. I'd like to never be prompted and have all new conversations opened without encryption. Is that possible?

You can toss a PR our way if you'd like to see this implemented - otherwise it probably won't happen.

I can understand why one may want not to enable E2E encryption in MUCs (hence why toggle in the settings affects 1-on-1 chats only), but I strongly believe that all non-group chats should be encrypted at all times, especially when using public XMPP service.

josephmturner commented 3 months ago

You can toss a PR our way if you'd like to see this implemented - otherwise it probably won't happen.

Okay! I may do that.

I can understand why one may want to not enable E2E encryption in MUCs (hence why toggle in the settings affects 1-on-1 chats only), but I strongly believe that all non-group chats should be encrypted at all times, especially when using public XMPP service.

I think the default should push users toward encryption (like it does!), but in my case as a https://jmp.chat user, nearly all of my contacts are on the telephony network where encryption isn't possible.

In any case, thank you for this fork of Dino! It's great to see development continue. :)

giantplaceholder commented 3 months ago

You can toss a PR our way if you'd like to see this implemented - otherwise it probably won't happen.

Okay! I may do that.

I can understand why one may want to not enable E2E encryption in MUCs (hence why toggle in the settings affects 1-on-1 chats only), but I strongly believe that all non-group chats should be encrypted at all times, especially when using public XMPP service.

I think the default should push users toward encryption (like it does!), but in my case as a https://jmp.chat user, nearly all of my contacts are on the telephony network where encryption isn't possible.

In any case, thank you for this fork of Dino! It's great to see development continue. :)

Ah, I see - you're using this gateway as a way to send out or receive SMS with your device.

Apologies - I haven't been using SMS daily for more than 15 years, so I can't really assess value of such service to others.

As for this service - are its operators open to suggestions re: its functionality? Maybe it would be a better way to go, don't you think?

josephmturner commented 3 months ago

Ah, I see - you're using this gateway as a way to send out or receive SMS with your device.

Apologies - I haven't been using SMS daily for more than 15 years, so I can't really assess value of such service to others.

As for this service - are its operators open to suggestions re: its functionality? Maybe it would be a better way to go, don't you think?

AFAIU, the only way for encryption to work over SMS is if both parties install a client which supports encryption like Silence.

Instead of attempting to shoehorn encryption into SMS, I prefer to ask my contacts to install an XMPP client which supports encryption. However, I still have many contacts on the SMS network for whom XMPP isn't a good option.

That said, I do think the JMP folks are open to suggestions, and I'd be happy to pass along ideas!

giantplaceholder commented 3 months ago

Ah, I see - you're using this gateway as a way to send out or receive SMS with your device. Apologies - I haven't been using SMS daily for more than 15 years, so I can't really assess value of such service to others. As for this service - are its operators open to suggestions re: its functionality? Maybe it would be a better way to go, don't you think?

AFAIU, the only way for encryption to work over SMS is if both parties install a client which supports encryption like Silence.

Instead of attempting to shoehorn encryption into SMS, I prefer to ask my contacts to install an XMPP client which supports encryption. However, I still have many contacts on the SMS network for whom XMPP isn't a good option.

That said, I do think the JMP folks are open to suggestions, and I'd be happy to pass along ideas!

No, my meaning was to at least keep the messages encrypted in transit until jump service, with the contents afterwards being their responsibility.

josephmturner commented 3 months ago

No, my meaning was to at least keep the messages encrypted in transit until jump service, with the contents afterwards being their responsibility.

Ah, I see. This may already be supported.

Another consideration is that I often use the jabber.el Emacs XMPP client, which doesn't have support for OMEMO or PGP.