Visualization script update

mxmssh / drltrace

Drltrace is a library calls tracer for Windows and Linux applications.

BSD 3-Clause "New" or "Revised" License

388 stars 68 forks source link

Visualization script update #25

Closed CedricHerzog closed 4 years ago

CedricHerzog commented 4 years ago

Adds a python3 version of the visualization script
Applies the PeP8 code style convention: https://www.python.org/dev/peps/pep-0008/
Remove unused var
Adds a requirements file to facilitate the installation

This script was tested briefly but seems to run ok

mxmssh commented 4 years ago

Hi Cedric, thank you for your contribution!

Would it make more sense to apply these changes the original script instead of creating a new file? Python2 is deprecated and I believe there is no need to support it anymore.

CedricHerzog commented 4 years ago

Hi, thank you for your tool :-)

Yes, it could be better to go fully to python 3. But, as I had no tests to run on it, I chose to keep the python 2 version also.

If you have written tests to check that there are no regressions, it is possible to apply the changes in the original script.

mxmssh commented 4 years ago

LGTM, thank you for the commit!