search

mxmxmx / temps_utile-

teensy 3.2 trigger generator
Other
146 stars 52 forks source link

some improvements (imo) #12

Closed jeremybernstein closed 7 years ago

jeremybernstein commented 7 years ago

Hi, a couple of small ideas for TU. First, I added some additional mult/div modes which are pretty useful -- this will break any saved mult/divs, though, since the count is different. A small price to pay.

Second, changing the multiplier or divider will not take effect until the next trigger. This solves the problem with channels getting out of sync with one another, but might have unanticipated side effects which I'm not considering. For instance, if users are relying on the out-of-syncness, or if they were pulling the cable and changing the mult after the fact, they're SOL. It also changes the musical character of mult/div changing, but it's a change for the better IMO.

My editor did a bunch of stripping of trailing whitespace, so that commit is there, too.

After flashing, resetting all channels and saving, I am no longer seeing the stray activity issue I reported previously.

mxmxmx commented 7 years ago

thanks!

jeremybernstein commented 7 years ago

Sure, I am in Basel this weekend, but I think I need to adjust the behavior of dividers (reset the div_cnt to 0 when a pending multiplier is set). I will check it out again on Sunday evening or Monday.