Pulsewidth and Global division setting no longer saved in v1.3

mxmxmx / temps_utile-

teensy 3.2 trigger generator

Other

146 stars 52 forks source link

Pulsewidth and Global division setting no longer saved in v1.3 #52

Open PooLP opened 3 years ago

PooLP commented 3 years ago

Hi, I merged a fix by @patrickdowling for this issue (https://github.com/mxmxmx/temps_utile-/issues/51) I started from latest version of this repos. I do not know if the project is still maintained or the project have another active repos.

Bye, Richard

patrickdowling commented 3 years ago

Generally if it's going into master the version number should be bumped also (so it's kind of preferable to merge from a version branch but we usually handled this somewhat on-the-fly). I will probably be doing a 1.4 on my repo anyway; I don't know if anyone will be doing a release here. Is there a reason why you rebased/changed the commits? The fix/misc branch is straight off master so there shouldn't have been any additional merges necessary.

PooLP commented 3 years ago

Cool for 1.4. This repos is inactive, so it is better to use yours ? I merged manually, that must be why and i have included your latest fix. I may have done a PR too quickly :hand_over_mouth:

patrickdowling commented 3 years ago

This repos is inactive, so it is better to use yours ?

I'd call mine marginally less inactive at best, not sure if that qualifies as "better" 😉