-save option broken?

[GoogleCodeExporter]

I just dropped 3.0.1 into the epub samples to test locally, and epubcheck no 
longer generates an archive when the "-mode exp -save" is specified, even 
though no errors are reported. Reverting back to RC-2 and it works again.

Running on Win7 with Java 7u25.

Original issue reported on code.google.com by mgarrish on 26 Jul 2013 at 1:37

[GoogleCodeExporter]

The -save works but you must give it a full path. This was introduced in 
correcting the issue 255. The last commit r510 corrects this behaviour.

Original comment by tledou...@gmail.com on 26 Jul 2013 at 4:51

[GoogleCodeExporter]

Ah, fantastic, thanks for the clarification! The structure of the epub samples 
project lends itself perfectly to the old behaviour, and with all the samples I 
completely missed that the files were being generated at the bottom of the \30 
subdirectory (I looked everywhere but there). Easy fix now that I know what's 
going on... please feel free to close.

Original comment by mgarrish on 27 Jul 2013 at 12:07

[GoogleCodeExporter]

Hi, with r457 I fixed saving in "-mode exp -save" so that the file is beeing 
saved in the same directory as the epub folder.

I changed from

   epubFile = new File(epubName);

to

   epubFile = new File(baseDir.getParent() + File.separator + epubName);

where basedir is the expanded folder itself, .getParent() gets the parent 
directory containing the expanded folder and epubName is the epub file to save.

Thomas, in r510 you changed to 

   epubFile = new File(baseDir.getParentFile(), epubName);

but what does it have to do with the "full path" issue you mention?

After r457 you are still able to validate expanded epubs and save the epub 
files - whether you use an absolute path or a relative one. However, in both 
cases the epub file isn't saved in the "working directory" anymore but nearby 
the expanded epub folder...

What am I missing? What were you trying to correct with your change in r510 ?

Original comment by tobias.c...@gmail.com on 3 Aug 2013 at 8:19

[GoogleCodeExporter]

In the case where you don't give a path, the baseDir.getParent() return an 
empty string, so the saved epubfile ended in root path (begining with \ or /) 
which was not the intended behavior. Using the File(File, name) constructor 
ensures everything goes smooth.

Original comment by tledou...@gmail.com on 9 Aug 2013 at 8:58

• Changed state: Fixed