search

mxpv / rps

Rust wrapper for AMD Render Pipeline Shaders SDK
Apache License 2.0
3 stars 0 forks source link

Bindings for rps #1

Open BeastLe9enD opened 1 year ago

BeastLe9enD commented 1 year ago

Hey! I saw that you are writing bindings for rps! Since I'm also writing bindings which are (at least for Vulkan) kind of working, I thought maybe we can work together, instead of having 2 bindings in the end :) If you are interested, check out my project: https://github.com/ProjectKML/render-pipeline-shaders-rs

mxpv commented 1 year ago

Hey @BeastLe9enD ! I'm happy to work together on this. Would you be interested in consolidating the work and opening a PR in this repo? (I'm also happy to add you as co-maintainer).

BeastLe9enD commented 1 year ago

Hey, consolidating sounds like an good idea! Since my version is already working and I am using it in another project, and someone else also wants to contribute, I would be very happy if we took this as the original version. Since it's a Github organization I can invite you and give you permissions to push directly to the repository :)

Note that I'm using a forked version of the original at the moment which allows me to use dynamic functions from the rust-side Vulkan loader. I made an pull request to the original (See https://github.com/GPUOpen-LibrariesAndSDKs/RenderPipelineShaders/pull/7) which has not been merged yet.

mxpv commented 1 year ago

Since my version is already working and I am using it in another project, and someone else also wants to contribute, I would be very happy if we took this as the original version.

Hmm.. I've looked through the codebase and APIs are way different, so it'll be a breaking change. I'm not quite sure how do you want to migrate given that it's already in use in other projects?

BeastLe9enD commented 3 months ago

hey! since you have not updated the crate since 2022, I want to ask if you are fine with transfering the crates.io ownership so I can use the names rps and rps-sys for mine.