mxr576 / ddqg

Drupal Dependency Quality Gate
2 stars 0 forks source link

Do not flag Obsolete modules as Unsupported #8

Closed janmashat closed 10 months ago

janmashat commented 11 months ago

Based on Drupal standards, modules marked as Obsolete may still be supported.

For example based on this discussion in Slack, swiftmailer 8.x-2.4 is technically covered by the Drupal Security Team - even if the wording on the project page may indicate otherwise.

mxr576 commented 10 months ago

:exploding_head: :exploding_head: :exploding_head:

Another example that challenges the current categorization is https://www.drupal.org/project/variationcache. Since Drupal core 10.2.0 was released, the module was marked as "Obsolete" (also "Minimally maintained"), which should not be categorized as unsupported.

This feature is now available in Drupal 10.2! 🚀

Please uninstall and remove this module once you are using Drupal 10.2 or higher and have no more code mentioning the Drupal\variationcache namespace.

Suggested refactoring based on Drupal's FTW maintenance categorization: introduce a new "deprecated" list.

New rules:

A potential follow-up task: rename "unsupported" to "abandoned".

mxr576 commented 10 months ago

This is what happened after the split was introduced:

..and God bless missing validation rules on D.o packagist ;S

    // @todo Find a better approach for filtering out projects with invalid package names.
    //   conflict.drupal/dummy__common is invalid, it should have a vendor name, a forward slash,
    //   and a package name. The vendor and package name can be words
    //   separated by -, . or _. The complete name should match "^[a-z0-9]([_.-]?[a-z0-9]+)*/[a-z0-9](([_.]?|-{0,2})[a-z0-9]+)*$".
    if ('dummy__common' === $project_name) {
        return $carry;
    }