Open Shion1305 opened 10 months ago
Describe the bug / How To Reproduce My email is shion1305@gmail.com . Looks like google returns the following 2 images for my account.
shion1305@gmail.com
GHunt uses is_default_profile_pic to figure out whether the profile image is the default one or not.
is_default_profile_pic
https://github.com/mxrch/GHunt/blob/40018b7f414b3c45c94b5d753ca12cdaffd5bfc7/ghunt/helpers/utils.py#L57-L66
However if I pass the url for my default profile picture, it returns True. So looks like this does not work as expected.
I found that if the profile image is default, it has isDefault field, and otherwise it does not or it is false. I suggest that it should be judged by the isDefault field, like the logic for cover photos. https://github.com/mxrch/GHunt/blob/40018b7f414b3c45c94b5d753ca12cdaffd5bfc7/ghunt/parsers/people.py#L62-L65 Also the flag is not used by any other functions, so I think it can be removed.
isDefault
Describe the bug / How To Reproduce My email is
shion1305@gmail.com. Looks like google returns the following 2 images for my account.GHunt uses
is_default_profile_picto figure out whether the profile image is the default one or not.https://github.com/mxrch/GHunt/blob/40018b7f414b3c45c94b5d753ca12cdaffd5bfc7/ghunt/helpers/utils.py#L57-L66
However if I pass the url for my default profile picture, it returns True. So looks like this does not work as expected.
I found that if the profile image is default, it has
isDefaultfield, and otherwise it does not or it is false. I suggest that it should be judged by theisDefaultfield, like the logic for cover photos. https://github.com/mxrch/GHunt/blob/40018b7f414b3c45c94b5d753ca12cdaffd5bfc7/ghunt/parsers/people.py#L62-L65 Also the flag is not used by any other functions, so I think it can be removed.