mxre / winres

Create and set windows icons and metadata for executables with a rust build script
MIT License
297 stars 42 forks source link

Cannot put escaped quotes in resource strings #11

Closed anyputer closed 5 years ago

anyputer commented 5 years ago

When I put

[package.metadata.winres]
FileDescription = "A simple \"Hello, World!\" program."

in the Cargo.toml, it gave this error:

D:\projects\icon-test\target\release\build\icon-test-7fe8c39ee383430f\out\resource.rc(16) : error RC2104 : undefined keyword or key name: Hello

------
RC Error:

------

--- stderr
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Custom { kind: Other, error: StringError("Could not compile resource file") }', libcore\result.rs:1009:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Double quotes shouldn't break anything.

mxre commented 5 years ago

Seems to be an issue with rc.exe not recognizing \" as an escaped symbol I'll look into it

mxre commented 5 years ago

I think found a quick fix, for this issue but I'v not had the time to test it thoroughly. I push the new version to cargo.io later

anyputer commented 5 years ago

thanks