Escape quoted strings in resource file

mxre / winres

Create and set windows icons and metadata for executables with a rust build script

MIT License

297 stars 42 forks source link

Escape quoted strings in resource file #12

Closed mdsteele closed 5 years ago

mdsteele commented 5 years ago

This allows string values to contain things like quotes and backslashes. In particular, it allows paths such as the icon file to be Windows-style paths (with backslashes).

Based on this page, it looks like double-quotes should be escaped by using two in a row, but that other characters (such as backslashes) should be escaped the usual C way, with backslashes. I think this should provide a more complete fix for issue #11.

mxre commented 5 years ago

Good work! I didn't even consider this problem. I tested your code with path and manifests and it seems to work as intended.