implementing clear and fixing variable scoping

mxriverlynn / backbone.memento

store and restore your model's state

367 stars 51 forks source link

implementing clear and fixing variable scoping #2

Closed jondot closed 13 years ago

jondot commented 13 years ago

Hi Derick, I've implemented clear, actually started by calling it 'reset' because i needed it, but then saw that the model already contained such a thing and it was not implemented.

some more notes about code in commit body: https://github.com/jondot/backbone.memento/commit/4537b9fa0972ceff73e49a65ad5cbfa8dc9fbf3a

Hope this helps!

jondot commented 13 years ago

closing.. for some reason it didn't take both commits. will reissue.

mxriverlynn commented 13 years ago

i think github is "smart" about topic branches... when you make changes in a topic branch and send the pull request from that branch, it will automatically include additional commits from that branch. but when you make commits directly to master, it only includes the commits from the point in time that the pull request was made.

... not sure if that's 100% accurate, but that's how i've seen it work, recently