search

mxriverlynn / backbone.picky

selectable entities as mixins for Backbone.Model and Backbone.Collection
129 stars 29 forks source link

New features: PR or fork? #31

Open hashchange opened 10 years ago

hashchange commented 10 years ago

Hi Derick,

I have added quite a bit of stuff to Backbone.Picky recently, as you perhaps have noticed. I wanted to have these features around for a project of mine, and thought they might be worth sharing.

That said, I realize that they change the character of your project to some extent. It has been simple and dead easy to adapt; the feature set was minimalistic; reading and understanding every aspect of the code took just a couple of minutes. My additions aren't complex by any means, but still, that kind of simplicity is no longer there.

So I wonder which way things should go. I certainly don't want to swamp you with unwanted PRs. If you'd like to pull the changes, that would certainly be great. But I could just as well turn it into an independent repo of my own, rename it for Bower, and keep the new stuff there. (You'd be credited, of course.)

Either way is fine with me. What are your thoughts?

Cheers,

Michael

hashchange commented 10 years ago

I didn't get hold of you on Twitter either, so eventually I have turned it into a separate project, here: Backbone.Select, also available on Bower as (surprise) backbone.select.

tony commented 10 years ago

@derickbailey @hashchange Can you get travis up and running so PR's can run against specs automatically for both projects?

What is the status of both of these projects atm?

hashchange commented 10 years ago

@tony So far I haven't had any pull requests, so I don't think I'll set up travis just yet.

Currently I don't have new features in the pipeline for Backbone.Select - it does what I want it to do, and does it well -, but suggestions and PRs are always welcome, so go ahead :)