search

mxriverlynn / rabbus

A micro-service bus with built-in messaging patterns, for NodeJS and RabbitMQ
116 stars 26 forks source link

move to rabbot as base, instead of wascally #26

Closed mxriverlynn closed 8 years ago

mxriverlynn commented 8 years ago

This pull request changes out the old, deprecated wascally library for the updated / maintained rabbot library.

and because of poor planning on my part, way back when i was doing this work, this PR also includes previous work on building out a new topology definition object. it should be backward compatible with previous versions of the rabbus API.

fixes #25

rhyslbw commented 8 years ago

Have you come across git-flow before? If not check this out: http://danielkummer.github.io/git-flow-cheatsheet/. In this case it would help to keep this PR free from release concerns, and show you the value of treating the develop branch as a staging area for the next release. With this approach the version number stays the same in any feature or fix branches and changelog items added under a headingvNext.

Also considering node 4 is a dependency, have you considered using ES6 classes?

mxriverlynn commented 8 years ago

this branch is definitely broken

i didn't realize i had a bunch of unit tests disabled, when i made this PR. still have a lot of work to do, as the change from wascally to rabbot was definitely not just drop-in-done.

mxriverlynn commented 8 years ago

v0.8.0 is now updated to use rabbot instead of wascally