search

mxschmitt / action-tmate

Debug your GitHub Actions via SSH by using tmate to get access to the runner system itself.
https://mxschmitt.github.io/action-tmate/
MIT License
2.86k stars 285 forks source link

Default to using public key authentication (if any public SSH key is registered) #153

Closed dscho closed 1 year ago

dscho commented 1 year ago

This PR intends to implement a less heavy-handed solution than suggested in https://github.com/mxschmitt/action-tmate/issues/124: Instead of changing the default of limit-access-to-actor to true, it introduces a new auto mode and makes that the new default. This mode will look for public SSH keys in the actor's GitHub profile, and use them if found, otherwise warn and continue without public key authentication.

mxschmitt commented 1 year ago

Sounds like a new major version release candidate then.

dscho commented 1 year ago

Sounds like a new major version release candidate then.

@mxschmitt Yes! Question is: how major. v4? Or could we say that, as semantic versioning goes, this only introduces new behavior, i.e. v3.15?

mxschmitt commented 1 year ago

Sorry for the late reply.

Sounds like a new major version release candidate then.

@mxschmitt Yes! Question is: how major. v4? Or could we say that, as semantic versioning goes, this only introduces new behavior, i.e. v3.15?

Fine for me as v3.15.