[Suggestion] Start tmate using the '-F' option

mxschmitt / action-tmate

Debug your GitHub Actions via SSH by using tmate to get access to the runner system itself.

https://mxschmitt.github.io/action-tmate/

MIT License

2.95k stars 289 forks source link

[Suggestion] Start tmate using the '-F' option #160

Closed seifferth closed 1 year ago

seifferth commented 1 year ago

See https://tmate.io/#remote_access. This particular commit is merely a suggestion, though. It is by no means a finished implementation – although it can serve as a working proof of concept.

dscho commented 1 year ago

Interesting idea!

From the text of the documentation, it would appear that this might be desirable in action-tmate's context.

However, I am relatively certain that we do not want -F here:

it keeps the tmate session in the foreground, giving action-tmate no chance to output the specific messages it wants to provide
it keeps re-spawning the tmate session when the last shell was closed, but we do want to exit in that case so that the GitHub workflow can continue

seifferth commented 1 year ago

That does sound like you have good reasons for doing what you're doing. It was just a quick idea anyhow. Thanks for the quick feedback and feel free to see this as resolved; from my point of view at least.

Best

Frank