mxschmitt / action-tmate

Debug your GitHub Actions via SSH by using tmate to get access to the runner system itself.
https://mxschmitt.github.io/action-tmate/
MIT License
2.95k stars 289 forks source link

The `save-state` command is deprecated #170

Closed rfay closed 1 year ago

rfay commented 1 year ago

When tmate starts up I see:

==> Installing tmate
==> Pouring tmate--2.4.0.monterey.bottle.tar.gz
🍺  /usr/local/Cellar/tmate/2.4.0: 9 files, 677.6KB
ssh N8sY8h4pM5QLhAgy6kaqnVNbG@nyc1.tmate.io

Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

So that seems to imply that tmate is using this feature that they don't want us to use any more.

The article on the GitHub blog does show them having delayed the disabling for some time now, but they are ramping up the pressure.

This is tmate--2.4.0.monterey.bottle.tar.gz on macos-latest GitHub runner.

mxschmitt commented 1 year ago

Could you share your GitHub workflow with us? Or the step where you consume us? Are you using v3?

rfay commented 1 year ago

Thanks for the quick response. Sorry, I thought everybody was seeing this.

The workflow is https://github.com/ddev/ddev/blob/master/.github/workflows/colima-tests.yml

An example run (with tmate enabled) is at https://github.com/ddev/ddev/actions/runs/5878893665/job/15941867962

##[debug]Generated SSH-Key successfully
##[debug]Executing shell command: [echo 'set +e' >/tmp/tmate.bashrc]
##[debug]Creating new session
##[debug]Executing shell command: [tmate -S /tmp/tmate.sock -a "/Users/runner/.ssh/authorized_keys" set-option -g default-command "bash --rcfile /tmp/tmate.bashrc" \; new-session -d]
##[debug]Executing shell command: [tmate -S /tmp/tmate.sock wait tmate-ready]
##[debug]Created new session successfully
##[debug]Fetching connection strings
##[debug]Executing shell command: [tmate -S /tmp/tmate.sock display -p '#{tmate_ssh}']
ssh DLLQ59p8xZbKeCpxGyvbVJEug@nyc1.tmate.io
##[debug]Executing shell command: [tmate -S /tmp/tmate.sock display -p '#{tmate_web}']
::save-state name=isPost::true
Warning: The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
##[debug]Save intra-action state isPost = true
##[debug]Entering main loop
megalithic commented 1 year ago

Seeing it here too, same set as @rfay for the tmate action.

rfay commented 1 year ago

Thanks!