Closed Vampire closed 2 months ago
Thank you for your contribution! We don't feel comfortable promoting non-standard tooling.
Totally understandable, but thanks for considering, and thanks for the awesome action, saved my ass a couple of times already. :-) If it is only the note in the readme that bugs you, I can of course remove it. The typing per-se is independent of any tooling and is merely a piece of documentation, just formalized in a way it can be helpful for users and tooling alike.
I would like to see your action first-class supported by https://github.com/typesafegithub/github-workflows-kt, a Kotlin DSL to write GitHub Action workflows.
The project came up with ways to reduce operational load when keeping the library's action wrappers in sync with actions' inputs and outputs. The solutions include onboarding https://github.com/typesafegithub/github-actions-typing. It is as easy as adding an extra YAML file to your repository root, and (optionally) adding a simple GitHub workflow that validates this new file. Thanks to this, the code generator in the Kotlin DSL can fetch typing info provided by you instead of them, which has a number of benefits. It has no negative effects on current action consumers, they continue to use the action via regular GitHub API, as if the file was not there.
In this pull request, I would like to ask you if you are open to introduce such typings in your action and also provide the current state as far as I could determine it. You would not be the first, there are already other actions using it, like e.g. my https://github.com/Vampire/setup-wsl or also Microsoft's https://github.com/microsoft/setup-msbuild.
Also "regular" users can benefit from this clear and formalized typing definition, seeing exactly what values are valid. And as the typings are made independent from the Kotlin DSL library, also other DSL or similar consumers could use these typings in the future.
When accepting this PR and in the future maintaining the typing yourself, please keep in mind that API are generated from these typing information. So if you for example recognize that a type is wrong and want to change it for example from
string
tointeger
, this would be a breaking change for such consumers and should therefore be done with a major version bump. Backwards compatible changes like new enum options, or new inputs or outputs can of course be released in a minor version as usual.After hopefully merging this PR it would be nice if you could cut a release soon, so that the shiny new typings can be used right away.