mxschmitt / fritzbox_exporter

Prometheus Exporter for FRITZ!Box (TR64 and UPnP)
https://mxschmitt.github.io/fritzbox_exporter
Apache License 2.0
58 stars 17 forks source link

Replace TotalBytesSent and TotalBytesReceived #24

Closed nachfuellbar closed 3 years ago

nachfuellbar commented 3 years ago

replace both variables through the 64 byte ones because the variables are formatted as a string there is an additional change in fritzboxmetrics.go

mxschmitt commented 3 years ago

Hi @nachfuellbar thanks for you contribution! Did you test it on your system? Then we can merge I think.

nachfuellbar commented 3 years ago

Yep and it's working

btw the typo was copy and paste - you should replace the one some lines later too ;)

gateway_wan_bytes_receive_rate{gateway="fritz.box"} 5084
gateway_wan_bytes_received{gateway="fritz.box"} 1.9151830035e+10
gateway_wan_bytes_send_rate{gateway="fritz.box"} 6772
gateway_wan_bytes_sent{gateway="fritz.box"} 3.369153505e+09
gateway_wan_connection_status{gateway="fritz.box"} 1
gateway_wan_connection_uptime_seconds{gateway="fritz.box"} 70272
gateway_wan_layer1_downstream_max_bitrate{gateway="fritz.box"} 2.85305e+08
gateway_wan_layer1_link_status{gateway="fritz.box"} 1
gateway_wan_layer1_upstream_max_bitrate{gateway="fritz.box"} 4.441e+07
gateway_wan_packets_received{gateway="fritz.box"} 1.0456098e+07
gateway_wan_packets_sent{gateway="fritz.box"} 6.46255e+06
mxschmitt commented 3 years ago

Yep and it's working

btw the typo was copy and paste - you should replace the one some lines later too ;)

gateway_wan_bytes_receive_rate{gateway="fritz.box"} 5084
gateway_wan_bytes_received{gateway="fritz.box"} 1.9151830035e+10
gateway_wan_bytes_send_rate{gateway="fritz.box"} 6772
gateway_wan_bytes_sent{gateway="fritz.box"} 3.369153505e+09
gateway_wan_connection_status{gateway="fritz.box"} 1
gateway_wan_connection_uptime_seconds{gateway="fritz.box"} 70272
gateway_wan_layer1_downstream_max_bitrate{gateway="fritz.box"} 2.85305e+08
gateway_wan_layer1_link_status{gateway="fritz.box"} 1
gateway_wan_layer1_upstream_max_bitrate{gateway="fritz.box"} 4.441e+07
gateway_wan_packets_received{gateway="fritz.box"} 1.0456098e+07
gateway_wan_packets_sent{gateway="fritz.box"} 6.46255e+06

cool great! I currently unfortunately have no Fritz box anymore, so it's hard for me to bring this project forward. If you are interested in contributing to it, let me know!