mxschmitt / golang-url-shortener

URL Shortener written in Golang using Bolt DB or Redis. Provides features such as Deletion, Expiration, OAuth and is of course Dockerizable.
https://so.sh0rt.cat
MIT License
283 stars 84 forks source link

first cut at redis support #100

Closed memory closed 6 years ago

memory commented 6 years ago

Also:

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 347


Changes Missing Coverage Covered Lines Changed/Added Lines %
stores/store.go 6 11 54.55%
stores/redis/redis.go 0 254 0.0%
<!-- Total: 6 265 2.26% -->
Totals Coverage Status
Change from base Build 290: -11.6%
Covered Lines: 409
Relevant Lines: 1079

💛 - Coveralls
mxschmitt commented 6 years ago

And thanks for you PR 👍

memory commented 6 years ago

Okay, the second commit in this PR should address the style concerns. Also I updated the README and the example config.yaml.

mxschmitt commented 6 years ago

As a final step please fix your comment styling to "MethodName ..." https://app.codacy.com/app/maxibanki/golang-url-shortener/pullRequest?prid=1621352

memory commented 6 years ago

55311f5 updates the comment styling to sentence format as requested.