search

mxschmitt / ui-driver-hetzner

Rancher UI driver for the Hetzner Cloud docker driver.
https://mxschmitt.github.io/ui-driver-hetzner
Apache License 2.0
254 stars 50 forks source link

Remove the serverLabels config if we don't set any labels #111

Closed NotANormalNerd closed 3 years ago

NotANormalNerd commented 3 years ago

Yes we could do that. I think it does not matter really, since we still have to delete the serverLabels. Since when it is available it will be given to the docker-machine-driver? (not entirely sure)

mxschmitt commented 3 years ago

Yes we could do that. I think it does not matter really, since we still have to delete the serverLabels. Since when it is available it will be given to the docker-machine-driver? (not entirely sure)

I think its cleaner if we do it there, since I already do the same with the networks there. Since a few days afaik and I changed it in the README also since a few days.

NotANormalNerd commented 3 years ago

I changed it. You are right. Doing this in validation is cleaner then doing this in the setLabel action.

mxschmitt commented 3 years ago

Thanks!