Closed mxsm closed 2 months ago
This update to the rocketmq-store
involves several noteworthy changes, including implementing a Display
trait for the GetMessageResult
struct for custom string formatting, introducing a ColdDataCheckService
for checking data presence in the page cache, and updating the CommitLog
and DefaultMessageStore
to integrate this service and improve logging. Additionally, the MessageStoreConfig
has a modified initial configuration value.
File Path | Change Summary |
---|---|
rocketmq-store/src/base/get_message_result.rs |
Implemented fmt::Display for GetMessageResult for custom string formatting. |
rocketmq-store/src/config/message_store_config.rs |
Changed access_message_in_memory_max_ratio initial value from 0 to 40 . |
rocketmq-store/src/log_file/commit_log.rs |
Introduced cold_data_check_service field and updated get_message method. |
rocketmq-store/src/log_file.rs , cold_data_check_service.rs |
Added ColdDataCheckService module and struct for checking data in page cache. |
rocketmq-store/src/message_store/default_message_store.rs |
Added logging using warn! macro for consumer request details. |
In the world of RocketMQ's delight,
GetMessageResult now shines so bright,
With a string format, clear and neat,
And cold data checks bring extra heat.
Logging whispers through the store,
Enhancing config ratios for more.
Code evolves, like a bunny's leap,
Into the future, strong and deep. 🐰✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
Attention: Patch coverage is 0%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 27.83%. Comparing base (
117b0f8
) to head (a743d88
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Which Issue(s) This PR Fixes(Closes)
Fixes #739
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
New Features
ColdDataCheckService
for enhanced data verification.CommitLog
for cold data checks.Improvements
DefaultMessageStore
for better debugging and traceability.Configuration Changes
access_message_in_memory_max_ratio
inMessageStoreConfig
from0
to40
.Code Formatting
GetMessageResult
.