mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUE ##748]🔥Implement message arrival notification for consumers🎨 #749

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #748

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 2 months ago

Walkthrough

The updates to RocketMQ include several refinements such as reordering initializer logic in BrokerRuntime, removal of an unnecessary log statement in DefaultPullMessageResultHandler, and enhancements to the ReputMessageService for handling message arrival notifications for multiple queues. These changes contribute to smoother operations and more efficient processing within the RocketMQ broker and store components.

Changes

Files Change Summary
rocketmq-broker/src/broker_runtime.rs Rearranged initialization of request_processor and fast_request_processor in start_basic_service method.
rocketmq-broker/src/processor/default_pull_message_result_handler.rs Removed the info! log statement under the ResponseCode::Success case.
rockemq-store/src/message_store/default_message_store.rs Updated ReputMessageService to handle message_store_config, additional fields, and utilized Arc for shared message store. New ReputMessageServiceInner struct included.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant BrokerRuntime
    participant Server
    participant RequestProcessor

    Client ->> BrokerRuntime: Call start_basic_service()
    BrokerRuntime ->> Server: Create Server
    BrokerRuntime ->> RequestProcessor: Init request_processor
    BrokerRuntime ->> RequestProcessor: Clone fast_request_processor
    BrokerRuntime ->>+ Server: Start server (tokio::spawn)
    BrokerRuntime -->>- Server: Running...

Assessment against linked issues

Objective Addressed Explanation
Implement message arrival notification for consumers (#748)

Poem

In code so swift, changes breeze, Fixes flow like gentle seas. Brokers start, now more precise, Consumers get their much due slice. Logs trimmed down, configs made neat, RocketMQ's rhythm takes its beat. 🚀🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 27.71%. Comparing base (b7f1fbb) to head (ec008e0).

Files Patch % Lines
...q-store/src/message_store/default_message_store.rs 0.00% 35 Missing :warning:
rocketmq-broker/src/broker_runtime.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #749 +/- ## ========================================== - Coverage 27.75% 27.71% -0.04% ========================================== Files 271 271 Lines 21487 21526 +39 ========================================== + Hits 5963 5966 +3 - Misses 15524 15560 +36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.