Closed mxsm closed 2 months ago
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
The updates to RocketMQ include several refinements such as reordering initializer logic in BrokerRuntime
, removal of an unnecessary log statement in DefaultPullMessageResultHandler
, and enhancements to the ReputMessageService
for handling message arrival notifications for multiple queues. These changes contribute to smoother operations and more efficient processing within the RocketMQ broker and store components.
Files | Change Summary |
---|---|
rocketmq-broker/src/broker_runtime.rs |
Rearranged initialization of request_processor and fast_request_processor in start_basic_service method. |
rocketmq-broker/src/processor/default_pull_message_result_handler.rs |
Removed the info! log statement under the ResponseCode::Success case. |
rockemq-store/src/message_store/default_message_store.rs |
Updated ReputMessageService to handle message_store_config , additional fields, and utilized Arc for shared message store. New ReputMessageServiceInner struct included. |
sequenceDiagram
participant Client
participant BrokerRuntime
participant Server
participant RequestProcessor
Client ->> BrokerRuntime: Call start_basic_service()
BrokerRuntime ->> Server: Create Server
BrokerRuntime ->> RequestProcessor: Init request_processor
BrokerRuntime ->> RequestProcessor: Clone fast_request_processor
BrokerRuntime ->>+ Server: Start server (tokio::spawn)
BrokerRuntime -->>- Server: Running...
Objective | Addressed | Explanation |
---|---|---|
Implement message arrival notification for consumers (#748) | ✅ |
In code so swift, changes breeze, Fixes flow like gentle seas. Brokers start, now more precise, Consumers get their much due slice. Logs trimmed down, configs made neat, RocketMQ's rhythm takes its beat. 🚀🐇
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Attention: Patch coverage is 0%
with 37 lines
in your changes missing coverage. Please review.
Project coverage is 27.71%. Comparing base (
b7f1fbb
) to head (ec008e0
).
Files | Patch % | Lines |
---|---|---|
...q-store/src/message_store/default_message_store.rs | 0.00% | 35 Missing :warning: |
rocketmq-broker/src/broker_runtime.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Which Issue(s) This PR Fixes(Closes)
Fixes #748
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
New Features
ReputMessageService
.Refactor
start_basic_service
for better performance and reliability.ReputMessageService
to improve code maintainability and performance.Bug Fixes