Closed shadowsoy closed 2 months ago
The process_request
function call within the process_request
method of an inner struct in pull_message_processor.rs
has been updated to process_request_inner
. The arguments have been modified, notably by removing RequestCode::from(request.code())
and adding false
and broker_allow_flow_ctr_suspend
. This update addresses a bug related to pull message execution when waking up.
Files/Modules | Change Summary |
---|---|
rocketmq-broker/src/processor/pull_message_processor.rs |
Renamed the process_request function call within a method to process_request_inner and modified its arguments, accommodating new parameters. |
The changes are too simple for a meaningful sequence diagram, so this section is omitted.
Objective | Addressed | Explanation |
---|---|---|
Fix Pull Message execute_request_when_wakeup (#759) | ✅ |
In code's quiet realm, a change was made,
process_request_inner
now takes the grade.
Withfalse
and flow control at its side,
Bugs will vanish, issues will subside.
RocketMQ's pull wakes up with pride.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
Which Issue(s) This PR Fixes(Closes)
Fixes #759
Brief Description
How Did You Test This Change?
Summary by CodeRabbit