search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
614 stars 80 forks source link

[ISSUE #786]🚀Optimize SendMessageRequestHeader and SendMessageRequestHeaderV2🔥 #787

Closed mxsm closed 3 months ago

mxsm commented 3 months ago

…HeaderV2🔥

Which Issue(s) This PR Fixes(Closes)

Fixes #786

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The updates primarily focus on optimizing how topics and other string fields are handled across the RocketMQ broker and remoting modules. This includes switching from explicit string cloning to using string references, thereby improving performance and simplifying the code. Additionally, new structures and methods were introduced to enhance the functionality and consistency in message header handling.

Changes

File Path Change Summary
rocketmq-broker/src/processor/send_message_processor.rs Updated topic handling by removing explicit string conversions.
rocketmq-broker/src/topic/manager/topic_queue_mapping_manager.rs Converted topic fields to string for consistency within TopicQueueMappingContext.
rocketmq-remoting/src/protocol/header/message_operation_header.rs Updated return types of TopicRequestHeaderTrait functions to return string references. Added send_message_request_header_v2 module.
rocketmq-remoting/src/protocol/header/send_message_request_header.rs Restructured SendMessageRequestHeader, removed SendMessageRequestHeaderV2, added serialization/deserialization traits.
rocketmq-remoting/src/protocol/header/send_message_request_header_v2.rs Introduced SendMessageRequestHeaderV2 struct with new fields and methods for enhanced message header handling.
rocketmq-remoting/src/protocol/header/pull_message_request_header.rs Converted string return types to references and replaced clone() with as_str() and as_deref().
rocketmq-remoting/src/protocol/header/query_consumer_offset_request_header.rs Modified string return types to references for performance optimization.
rocketmq-remoting/src/protocol/header/update_consumer_offset_header.rs Switched string return types to references and used as_deref() instead of clone().

Assessment against linked issues

Objective Addressed Explanation
Optimize SendMessageRequestHeader and introduce SendMessageRequestHeaderV2 (Issue #786) ✅

Poem

In codes of RocketMQ we delve,
Strings to references, we soon shelve.
Headers optimized with swift delight,
Performance gains are now in sight.
🐇 A rabbit's joy in every byte,
Enhanced and streamlined, pure and bright. 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 58.18966% with 194 lines in your changes missing coverage. Please review.

Project coverage is 27.65%. Comparing base (fc852cd) to head (297a0f6).

Files Patch % Lines
...operation_header/send_message_request_header_v2.rs 54.70% 130 Missing :warning:
...ge_operation_header/send_message_request_header.rs 72.90% 42 Missing :warning:
...r/src/topic/manager/topic_queue_mapping_manager.rs 0.00% 6 Missing :warning:
...tmq-broker/src/processor/send_message_processor.rs 0.00% 4 Missing :warning:
...src/protocol/header/pull_message_request_header.rs 0.00% 4 Missing :warning:
...col/header/query_consumer_offset_request_header.rs 0.00% 4 Missing :warning:
...c/protocol/header/update_consumer_offset_header.rs 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #787 +/- ## ========================================== + Coverage 27.34% 27.65% +0.30% ========================================== Files 288 289 +1 Lines 22869 23120 +251 ========================================== + Hits 6254 6394 +140 - Misses 16615 16726 +111 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.