search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
614 stars 80 forks source link

[ISSUE #788]⚡️Optimize and refine the process of sending messages🚀 #789

Closed mxsm closed 3 months ago

mxsm commented 3 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #788

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes introduce optimizations and refinements to the process of sending messages in RocketMQ. Key updates include replacing Arc<RwLock<Vec<Box<dyn SendMessageHook>>> with ArcCellWrapper, modifying method signatures for better handling of request codes, and updating the BrokerConfig struct to enhance performance. Additionally, a new inline function is added to the RocketMQMessageStore trait.

Changes

File Path Change Summary
rocketmq-broker/src/processor.rs Replaced Arc<RwLock<Vec<Box<dyn SendMessageHook>>> with ArcCellWrapper, updated method signatures, and property access.
rocketmq-broker/src/processor/send_message_processor.rs Imported ArcCellWrapper, modified method implementations, removed debug logging.
rocketmq-common/src/common/broker/broker_config.rs Updated region_id to return &str and added get_broker_addr method.
rocketmq-remoting/src/protocol/header/message_operation_header/send_message_request_header.rs Updated parse_request_header to include request_code parameter.
rocketmq-store/src/log_file.rs Added now method to RocketMQMessageStore trait.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant SendMessageProcessorInner
    participant SendMessageHook
    participant BrokerConfig

    Note over Client,SendMessageProcessorInner: Send message flow
    Client->>SendMessageProcessorInner: send_message(request)
    SendMessageProcessorInner->>BrokerConfig: get_broker_addr()
    BrokerConfig-->>SendMessageProcessorInner: broker_addr
    SendMessageProcessorInner->>SendMessageHook: execute_send_message_hook_before(context)
    SendMessageHook-->>SendMessageProcessorInner: hook executed
    SendMessageProcessorInner->>SendMessageHook: execute_send_message_hook_after(response, context)
    SendMessageHook-->>SendMessageProcessorInner: hook executed
    SendMessageProcessorInner->>Client: send_message_response

    Note over Client,SendMessageProcessorInner: Batch message flow
    Client->>SendMessageProcessorInner: send_batch_message(request)
    SendMessageProcessorInner->>BrokerConfig: get_broker_addr()
    BrokerConfig-->>SendMessageProcessorInner: broker_addr
    SendMessageProcessorInner->>SendMessageHook: execute_send_message_hook_before(context)
    SendMessageHook-->>SendMessageProcessorInner: hook executed
    SendMessageProcessorInner->>SendMessageHook: execute_send_message_hook_after(response, context)
    SendMessageHook-->>SendMessageProcessorInner: hook executed
    SendMessageProcessorInner->>Client: send_batch_message_response

Assessment against linked issues

Objective Addressed Explanation
Optimize and refine the process of sending messages (#788) ✅

Poem

In a world where messages fly, RocketMQ reaches for the sky. With ArcCellWrapper in its core, Efficiency is hard to ignore. Hooks now quicker, sleek and bright, Sending messages, oh what a delight! 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 27.65%. Comparing base (55da831) to head (5207da9).

Files Patch % Lines
rocketmq-broker/src/processor.rs 0.00% 19 Missing :warning:
rocketmq-common/src/common/broker/broker_config.rs 0.00% 5 Missing :warning:
...tmq-broker/src/processor/send_message_processor.rs 0.00% 2 Missing :warning:
...ge_operation_header/send_message_request_header.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #789 +/- ## ========================================== - Coverage 27.66% 27.65% -0.02% ========================================== Files 289 289 Lines 23120 23128 +8 ========================================== - Hits 6397 6395 -2 - Misses 16723 16733 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.