search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
614 stars 80 forks source link

[ISSUE #790]🚀Support Query message(request code :12,33)🔥 #791

Closed mxsm closed 3 months ago

mxsm commented 3 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #790

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The update introduces QueryMessageProcessor to enhance RocketMQ's message querying and viewing capabilities. This includes asynchronous methods for querying messages by attributes and viewing messages by ID. Changes span across rocketmq-broker, rocketmq-remoting, and rocketmq-store modules, adding new headers, structs, and methods to support the new functionality.

Changes

Files/Paths Change Summary
rocketmq-broker/src/broker_runtime.rs Added QueryMessageProcessor initialization, cloned message_store, and updated BrokerRuntime struct.
rocketmq-broker/src/processor.rs Updated QueryMessageProcessor to be generic, handled new RequestCode variants.
rocketmq-broker/src/processor/query_message_processor.rs Made QueryMessageProcessor generic, added async methods for request processing.
rocketmq-remoting/src/protocol/header.rs Added new modules for query and view message request/response headers.
rocketmq-remoting/src/protocol/header/query_message_request_header.rs Added QueryMessageRequestHeader with serialization/deserialization methods and unit tests.
rocketmq-remoting/src/protocol/header/query_message_response_header.rs Added QueryMessageResponseHeader struct with traits for serialization/deserialization.
rocketmq-remoting/src/protocol/header/view_message_request_header.rs Added ViewMessageRequestHeader struct with public fields and serialization/deserialization traits.
rocketmq-remoting/src/protocol/header/view_message_response_header.rs Added ViewMessageResponseHeader struct with traits for serialization/deserialization.
rocketmq-remoting/src/rpc/topic_request_header.rs Modified to_map method to handle rpc_request_header differently.
rocketmq-store/src/base.rs Added query_message_result module for handling query results.
rocketmq-store/src/base/query_message_result.rs Introduced QueryMessageResult struct with methods for message data management.
rocketmq-store/src/base/select_result.rs Added methods get_buffer_slice_mut and get_bytes to SelectMappedBufferResult.
rocketmq-store/src/index/index_service.rs Modified query_offset parameters to use &str instead of String.
rocketmq-store/src/index/query_offset_result.rs Added get_phy_offsets_mut method to QueryOffsetResult struct.
rocketmq-store/src/log_file.rs Introduced async methods for querying/selecting messages, adjusted signatures to use new types.
rocketmq-store/src/message_store/default_message_store.rs Added imports and new async methods for querying/selecting messages by various criteria.

Assessment against linked issues

Objective ($issue numbers) Addressed Explanation
Support Query message(request code :12,33) (#790) ✅

In the realms of RocketMQ's might, Query messages come to light. With processors and headers so bright, They enhance our broker's flight. Messages now query, view, and delight, RocketMQ soars to a new height. 🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 30.46595% with 194 lines in your changes missing coverage. Please review.

Project coverage is 27.73%. Comparing base (4f59378) to head (66cd887).

Files Patch % Lines
...mq-broker/src/processor/query_message_processor.rs 0.00% 71 Missing :warning:
...q-store/src/message_store/default_message_store.rs 0.00% 64 Missing :warning:
rocketmq-store/src/base/query_message_result.rs 0.00% 19 Missing :warning:
...rc/protocol/header/query_message_request_header.rs 90.32% 9 Missing :warning:
rocketmq-store/src/base/select_result.rs 0.00% 9 Missing :warning:
rocketmq-store/src/index/index_service.rs 0.00% 5 Missing :warning:
rocketmq-broker/src/broker_runtime.rs 0.00% 3 Missing :warning:
rocketmq-broker/src/processor.rs 0.00% 3 Missing :warning:
...c/protocol/header/query_message_response_header.rs 0.00% 3 Missing :warning:
...src/protocol/header/view_message_request_header.rs 0.00% 3 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #791 +/- ## ========================================== + Coverage 27.65% 27.73% +0.07% ========================================== Files 289 294 +5 Lines 23128 23400 +272 ========================================== + Hits 6397 6490 +93 - Misses 16731 16910 +179 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.