Closed mxsm closed 2 months ago
The changes make the topic_queue_lock
module public, modify the MessageStoreConfig
default to set topic_queue_lock_num
to 32, and integrate TopicQueueLock
into the CommitLog
struct to optimize the put_message
method with new lock functionality.
File | Change Summary |
---|---|
rocketmq-store/src/base.rs |
Made topic_queue_lock module public. |
rocketmq-store/src/config/message_store_config.rs |
Changed the default value of topic_queue_lock_num to 32. |
rocketmq-store/src/log_file/commit_log.rs |
Integrated TopicQueueLock , added topic_queue_lock field, and used it in CommitLog methods. |
Objective (Issue) | Addressed | Explanation |
---|---|---|
Optimize CommitLog#put_message method by adding TopicQueueLock (#802) |
✅ |
In lines of code, a change took flight, A queue lock now in plain sight. CommitLog's message put to the test, With locks in place, it’s at its best. Thirty-two locks now stand in line, RocketMQ’s future, bright and fine. 🚀🐇🔒
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
Attention: Patch coverage is 0%
with 12 lines
in your changes missing coverage. Please review.
Project coverage is 28.16%. Comparing base (
a2560ea
) to head (56c2e6e
).
Files | Patch % | Lines |
---|---|---|
rocketmq-store/src/log_file/commit_log.rs | 0.00% | 12 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Which Issue(s) This PR Fixes(Closes)
Fixes #802
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
New Features
topic_queue_lock_num
from 0 to 32, enhancing default performance.CommitLog
functionality with a newtopic_queue_lock
feature, improving data integrity and concurrent processing.Refactor
topic_queue_lock
module public to improve modularity and access across the codebase.