search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUE #811]🎨Refactor Client error handle🔥 #812

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #811

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago

Walkthrough

The recent changes enhance the RocketMQ server's architecture, particularly in client handling and error management. The modifications introduce a more robust remote client configuration and refactor error handling to utilize a custom result type, improving clarity and responsiveness. By removing outdated components and streamlining dependency management, these updates aim to elevate overall system performance and maintainability.

Changes

Files Change Summary
rocketmq-namesrv/src/bootstrap.rs Added RocketmqDefaultClient and TokioClientConfig to NameServerRuntime, enhancing remote communication capabilities; updated Builder to integrate new clients.
rocketmq-namesrv/src/processor/default_request_processor.rs Removed NamesrvConfig, refactored constructor to introduce new_with for better dependency management, simplifying instantiation.
rocketmq-namesrv/src/route/route_info_manager.rs Replaced remote_client with remoting_client of type Arc<RocketmqDefaultClient, updated constructor and notification handling for asynchronous execution.
rocketmq-remoting/src/clients.rs Completely removed RemoteClient and its methods, indicating a shift in client architecture towards simplicity and efficiency in remote interactions.
rocketmq-remoting/src/clients/blocking_client.rs Changed send method's return type to crate::Result<()>, refining error handling to use custom crate-defined errors for consistency.
rocketmq-remoting/src/clients/client.rs Updated methods to replace anyhow::Result with a custom Result, improving error handling by checking for connection issues and providing clearer messages.
rocketmq-remoting/src/error.rs Introduced new Error variants, ConnectionInvalid and Elapsed, enhancing the granularity of error reporting for asynchronous operations.

Assessment against linked issues

Objective Addressed Explanation
Refactor Client error handle (#811) ✅
Improve error clarity and handling (#811) ✅
Simplify client structure and dependencies ❌ Some components remain, indicating not all simplifications were addressed.

Poem

In the server's heart, new clients bloom,
With clearer paths, they banish the gloom.
Errors now speak, with voices so bright,
As rabbits hop through code, in pure delight! 🐇✨
Together we thrive, in a dance so grand,
RocketMQ's future, a wondrous land!

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 28.05%. Comparing base (6c65f51) to head (913c389).

Files Patch % Lines
rocketmq-remoting/src/clients/client.rs 0.00% 23 Missing :warning:
rocketmq-namesrv/src/route/route_info_manager.rs 0.00% 14 Missing :warning:
rocketmq-namesrv/src/bootstrap.rs 0.00% 9 Missing :warning:
rocketmq-remoting/src/error.rs 0.00% 4 Missing :warning:
...namesrv/src/processor/default_request_processor.rs 0.00% 2 Missing :warning:
rocketmq-remoting/src/clients/blocking_client.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #812 +/- ## ========================================== + Coverage 28.02% 28.05% +0.02% ========================================== Files 297 296 -1 Lines 23784 23764 -20 ========================================== Hits 6666 6666 + Misses 17118 17098 -20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.