Closed 847850277 closed 1 month ago
The recent changes to the rocketmq-broker
enhance the AdminBrokerProcessor
and TopicRequestHandler
by introducing a new asynchronous method for retrieving system topic lists from the broker. This addition enables the broker to better manage and respond to requests concerning system topics, thereby improving its administrative capabilities while maintaining the integrity of existing functionality.
Files | Change Summary |
---|---|
rocketmq-broker/src/processor/admin_broker_processor.rs rocketmq-broker/src/processor/admin_broker_processor/topic_request_handler.rs |
Added a new case in AdminBrokerProcessor to handle GetSystemTopicListFromBroker requests and implemented get_system_topic_list_from_broker in TopicRequestHandler to retrieve system topics. |
AdminBrokerProcessor
to get the system topic list from the broker, directly addressing the issue's objective.🐇 In the realm of code where brokers play,
A new path unfolds, brightening the way.
Topics now listed with a flick of a paw,
Enhancements abound, oh what a great law!
With hops of delight, we welcome the change,
Our Rabbit's delight, let it spread and arrange! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
Attention: Patch coverage is 0%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 27.18%. Comparing base (
9669e4f
) to head (d12fd55
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...or/admin_broker_processor/topic_request_handler.rs | 0.00% | 15 Missing :warning: |
...tmq-broker/src/processor/admin_broker_processor.rs | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥
Which Issue(s) This PR Fixes(Closes)
Fix #834
Brief Description
Support AdminBrokerProcessor get_system_topic_list_from_broker
How Did You Test This Change?
Summary by CodeRabbit
New Features
Bug Fixes
Documentation