search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUES #850] Support AdminBrokerProcessor get_topic_config. #853

Closed 847850277 closed 3 months ago

847850277 commented 3 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #850

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes implemented enhance the AdminBrokerProcessor and TopicRequestHandler to support retrieving topic configurations. A new request code, GetTopicConfig, is introduced, allowing for better management of topic settings and queue mappings. This expansion improves the messaging system's capabilities, facilitating more complex requests and responses related to topic configurations.

Changes

Files Change Summary
rocketmq-broker/src/processor/admin_broker_processor.rs, rocketmq-broker/src/processor/admin_broker_processor/topic_request_handler.rs Added handling for GetTopicConfig requests and implemented a new asynchronous method get_topic_config to retrieve topic configurations and queue mappings.
rocketmq-remoting/src/protocol/header.rs, rocketmq-remoting/src/protocol/header/get_topic_config_request_header.rs Introduced a new module and data structure GetTopicConfigRequestHeader for managing topic configuration requests, including serialization capabilities.
rocketmq-remoting/src/protocol/static_topic.rs, rocketmq-remoting/src/protocol/static_topic/topic_config_and_queue_mapping.rs Added a new module for TopicConfigAndQueueMapping, encapsulating topic configurations with queue mapping details.
rocketmq-remoting/src/rpc/topic_request_header.rs Enhanced TopicRequestHeader with new methods get_lo and set_lo for better access to the lo field.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant AdminBrokerProcessor
    participant TopicRequestHandler
    participant Response

    Client->>AdminBrokerProcessor: Send GetTopicConfig request
    AdminBrokerProcessor->>TopicRequestHandler: Call get_topic_config
    TopicRequestHandler->>TopicRequestHandler: Process request and retrieve config
    TopicRequestHandler->>Response: Return TopicConfigAndQueueMapping
    AdminBrokerProcessor->>Client: Send response with TopicConfig

Assessment against linked issues

Objective Addressed Explanation
Support AdminBrokerProcessor to handle get_topic_config requests. (#850) ✅
Enhance topic configuration management in the messaging system. (#850) ✅

🐇 In the meadow, hops a joyful rabbit,
With changes so fine, let’s all grab it!
Configs for topics, now clear and bright,
Hooray for the code, it’s a wonderful sight!
With queues all aligned, and requests in flow,
A happy little rabbit dances to and fro! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 73 lines in your changes missing coverage. Please review.

Project coverage is 26.10%. Comparing base (6017d85) to head (83765d4).

Files Patch % Lines
...or/admin_broker_processor/topic_request_handler.rs 0.00% 30 Missing :warning:
...protocol/header/get_topic_config_request_header.rs 0.00% 22 Missing :warning:
...col/static_topic/topic_config_and_queue_mapping.rs 0.00% 12 Missing :warning:
rocketmq-remoting/src/rpc/topic_request_header.rs 0.00% 6 Missing :warning:
...tmq-broker/src/processor/admin_broker_processor.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #853 +/- ## ========================================== - Coverage 26.19% 26.10% -0.09% ========================================== Files 322 324 +2 Lines 26013 26083 +70 ========================================== - Hits 6813 6808 -5 - Misses 19200 19275 +75 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.