search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUE #847]🚀Implement DefaultMQProducer#start-2 #855

Closed mxsm closed 1 month ago

mxsm commented 1 month ago

Which Issue(s) This PR Fixes(Closes)

Fixes #847

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes streamline the RocketMQ codebase by replacing ArcCellWrapper with ArcRefCellWrapper, enhancing thread-safe mutable access across various components. This transition improves state management in message handling, producer configurations, and client communications. Additionally, new modules and structures have been introduced to facilitate enhanced functionality, such as tracing and fault tolerance, while promoting better organization and modularity in the code.

Changes

Files Change Summary
rocketmq-broker/..., rocketmq-client/..., rocketmq-common/..., rocketmq-remoting/... Replaced ArcCellWrapper with ArcRefCellWrapper for various fields, improving mutable access in message handling.
rocketmq-client/Cargo.toml Added dependencies: tokio, tokio-util, tokio-stream, lazy_static, tracing for enhanced async capabilities.
rocketmq-client/src/base/client_config.rs Introduced namespace_initialized field in ClientConfig and added methods for improved state management.
rocketmq-client/src/factory/mq_client_instance.rs Added MQClientInstance struct for better client instance management.
rocketmq-client/src/producer/default_mq_produce_builder.rs, .../default_mq_producer.rs Transitioned fields from Box to Arc<Box> for better memory management in producers.
rocketmq-client/src/trace/... Introduced tracing capabilities through new modules and implementations, enhancing observability for transactions.
rocketmq-common/src/common/base/service_state.rs Created ServiceState enum for service state representation.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Producer
    participant Broker

    Client->>Producer: create instance
    Producer->>Broker: send message
    Broker-->>Producer: acknowledge receipt
    Producer-->>Client: confirmation

Assessment against linked issues

Objective Addressed Explanation
Implement DefaultMQProducer#start-2 (Issue #847) ✅

🐰✨ In the code where bunnies play,
RefCells lead the way!
With hooks and traces, oh so bright,
Message flows take graceful flight!
For every change, a hop of cheer,
Our RocketMQ is now more dear! 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 2.69360% with 289 lines in your changes missing coverage. Please review.

Project coverage is 25.92%. Comparing base (6017d85) to head (fe534c0).

Files Patch % Lines
...ocketmq-client/src/producer/default_mq_producer.rs 0.00% 79 Missing :warning:
rocketmq-client/src/base/client_config.rs 0.00% 38 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs 0.00% 37 Missing :warning:
...client/src/latency/latency_fault_tolerance_impl.rs 0.00% 25 Missing :warning:
...tmq-client/src/implementation/mq_client_manager.rs 0.00% 22 Missing :warning:
...ocketmq-client/src/trace/async_trace_dispatcher.rs 0.00% 16 Missing :warning:
...etmq-remoting/src/clients/rocketmq_default_impl.rs 0.00% 11 Missing :warning:
rocketmq-remoting/src/protocol/request_type.rs 0.00% 11 Missing :warning:
...ent/src/trace/hook/send_message_trace_hook_impl.rs 0.00% 8 Missing :warning:
.../src/trace/hook/end_transaction_trace_hook_impl.rs 0.00% 6 Missing :warning:
... and 15 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #855 +/- ## ========================================== - Coverage 26.19% 25.92% -0.27% ========================================== Files 322 332 +10 Lines 26013 26281 +268 ========================================== Hits 6813 6813 - Misses 19200 19468 +268 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.