search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #870] Implement DefaultMQProducerImpl#start #871

Closed mxsm closed 3 months ago

mxsm commented 3 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #870

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 3 months ago

[!IMPORTANT]

Review skipped

Auto reviews are limited to specific labels.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes enhance the RocketMQ client and broker functionalities by introducing several new modules, refining existing structures, and improving asynchronous handling. Key modifications include the addition of validation mechanisms, refactoring of the RPC hooks for better memory management, and the establishment of comprehensive message-pulling and rebalance services. These updates aim to bolster the robustness, modularity, and performance of the messaging system.

Changes

File(s) Change Summary
rocketmq-broker/src/out_api/broker_outer_api.rs Modified new_with_hook to accept Arc<Box<dyn RPCHook>>, enhancing flexibility of RPC hooks.
rocketmq-client/Cargo.toml Added rocketmq-runtime dependency for modularity.
rocketmq-client/src/admin.rs, rocketmq-client/src/admin/mq_admin_ext_inner.rs Introduced mq_admin_ext_inner module and MQAdminExtInner trait for message queue administration.
rocketmq-client/src/base.rs, rocketmq-client/src/base/validators.rs Added validators module; defined Validators struct with validation methods for messaging components.
rocketmq-client/src/consumer/*.rs Established new modules for consumer functionality, including pull_message_service and rebalance_service for managing message consumption.
rocketmq-client/src/factory/mq_client_instance.rs Enhanced MQClientInstance struct with new fields for thread-safe management of producers, consumers, and admin extensions; updated methods to be asynchronous.
rocketmq-common/Cargo.toml Removed log dependency; added reqwest, url, and form_urlencoded for enhanced HTTP capabilities.
rocketmq-common/src/common/message/message_single.rs Introduced get_user_property method in Message for retrieving user properties.
rocketmq-common/src/utils/http_tiny_client.rs Implemented HttpTinyClient for simplified HTTP requests, including GET and POST methods.
rocketmq-remoting/src/clients/rocketmq_default_impl.rs, rocketmq-remoting/src/remoting.rs Changed register_rpc_hook to accept Arc<Box<dyn RPCHook>> for better memory management and concurrency.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Producer
    participant Broker
    Client->>Producer: register_producer()
    Producer->>Broker: send_message()
    Broker-->>Producer: acknowledge()
    Producer-->>Client: confirmation()

Assessment against linked issues

Objective Addressed Explanation
Implement DefaultMQProducerImpl#start (870) ✅

🐇 Hopping through code so bright,
Our changes make the system right.
With hooks and clients working true,
Messaging magic now shines through!
🥕🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0.53476% with 372 lines in your changes missing coverage. Please review.

Project coverage is 25.41%. Comparing base (84aefe4) to head (e8c8729).

Files Patch % Lines
rocketmq-client/src/factory/mq_client_instance.rs 0.00% 108 Missing :warning:
rocketmq-client/src/base/validators.rs 0.00% 75 Missing :warning:
rocketmq-common/src/utils/http_tiny_client.rs 0.00% 61 Missing :warning:
...ommon/src/common/namesrv/default_top_addressing.rs 0.00% 52 Missing :warning:
...mq-client/src/implementation/mq_client_api_impl.rs 0.00% 42 Missing :warning:
rocketmq-common/src/common/mix_all.rs 0.00% 9 Missing :warning:
...src/consumer/consumer_impl/pull_message_service.rs 0.00% 4 Missing :warning:
...nt/src/consumer/consumer_impl/rebalance_service.rs 0.00% 4 Missing :warning:
...nt/src/implementation/client_remoting_processor.rs 0.00% 4 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs 0.00% 4 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #871 +/- ## ========================================== - Coverage 25.81% 25.41% -0.40% ========================================== Files 334 341 +7 Lines 26393 26751 +358 ========================================== - Hits 6813 6800 -13 - Misses 19580 19951 +371 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.