search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUES #860] Support AdminBrokerProcessor get_broker_runtime_info part#1 #877

Closed 847850277 closed 1 month ago

847850277 commented 1 month ago

Support AdminBrokerProcessor get_broker_runtime_info part#1

Which Issue(s) This PR Fixes(Closes)

Fixes #860

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes significantly enhance the RocketMQ broker's functionality and organization. Notable updates include improved handling of runtime information in the AdminBrokerProcessor, new capabilities for tracking statistics, and refined message store configurations. These modifications aim to create a more robust framework for effectively monitoring and managing broker operations.

Changes

Files Change Summary
rocketmq-broker/src/broker_runtime.rs, rocketmq-broker/src/processor/admin_broker_processor.rs Enhanced initialization in BrokerRuntime; updated AdminBrokerProcessor to include message storage and stats.
rocketmq-broker/src/processor/admin_broker_processor/broker_config_request_handler.rs Added get_broker_runtime_info async method for runtime info handling.
rocketmq-broker/src/schedule/schedule_message_service.rs Introduced build_running_stats method for tracking scheduled message statistics.
rocketmq-common/src/common.rs, rocketmq-common/src/common/running.rs Added new running and system_clock modules for improved functionality.
rocketmq-common/src/common/broker/broker_config.rs, rocketmq-store/src/config/message_store_config.rs New methods for enhanced configuration access.
rocketmq-common/src/common/mq_version.rs Introduced CURRENT_VERSION constant and formatted display traits for logging.
rocketmq-common/src/common/running/running_stats.rs Defined RunningStats enum for various performance metrics.
rocketmq-common/src/common/system_clock.rs New SystemClock struct for retrieving system time.
rocketmq-store/src/base/store_stats_service.rs Enhanced with new fields and methods for performance metrics retrieval.
rocketmq-store/src/log_file.rs, rocketmq-store/src/log_file/commit_log.rs, rocketmq-store/src/message_store/default_message_store.rs Added methods for runtime metrics and performance monitoring.

Assessment against linked issues

Objective Addressed Explanation
Support AdminBrokerProcessor get_broker_runtime_info (860) ✅
Enhance message store statistics tracking ✅
Improve runtime information handling ✅

Poem

In the land of bytes and bits,
A rabbit hops, where logic fits.
With new stats and info bright,
The broker glows, a splendid sight!
So let’s cheer for changes made,
In RabbitMQ, progress won't fade! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 368 lines in your changes missing coverage. Please review.

Project coverage is 25.05%. Comparing base (306b435) to head (b1e1fd7).

Files Patch % Lines
rocketmq-store/src/base/store_stats_service.rs 0.00% 240 Missing :warning:
..._broker_processor/broker_config_request_handler.rs 0.00% 82 Missing :warning:
...q-store/src/message_store/default_message_store.rs 0.00% 10 Missing :warning:
...tmq-broker/src/processor/admin_broker_processor.rs 0.00% 9 Missing :warning:
rocketmq-store/src/log_file/commit_log.rs 0.00% 7 Missing :warning:
rocketmq-common/src/common/system_clock.rs 0.00% 5 Missing :warning:
rocketmq-broker/src/broker_runtime.rs 0.00% 4 Missing :warning:
rocketmq-common/src/common/broker/broker_config.rs 0.00% 3 Missing :warning:
rocketmq-common/src/common/mq_version.rs 0.00% 3 Missing :warning:
rocketmq-store/src/config/message_store_config.rs 0.00% 3 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #877 +/- ## ========================================== - Coverage 25.42% 25.05% -0.37% ========================================== Files 341 342 +1 Lines 26751 27134 +383 ========================================== - Hits 6802 6799 -3 - Misses 19949 20335 +386 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.