[ISSUE #872]Implement Produer send single message-1

mxsm commented 3 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #872

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

New Features
- Added optional address handling in the invoke_async methods across several components, improving robustness in API interactions.
- Introduced new asynchronous methods for retrieving and updating topic route information in the MQClientInstance class.
- Enhanced Message struct with multiple constructors for flexible message creation.
Improvements
- Improved error handling and state management in the DefaultMQProducer class to enhance message sending reliability.
- Expanded MQConsumerInner trait with methods for dynamic subscription management and consumer state tracking.
- Enhanced SendMessageContext and CheckForbiddenContext structures for better message handling context.
Bug Fixes
- Addressed potential issues with message queue accessibility by exposing certain fields in the QueueData struct.
Refactor
- Simplified method signatures in various producer and consumer classes to improve the usability and flexibility of the API.

mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

mxsm commented 3 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 3 months ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The recent changes enhance the RocketMQ client and broker by introducing optional parameters for address handling, improving error management, and expanding the functionality of message sending, consumer management, and logging. Notably, the modifications allow for more robust asynchronous operations and flexibility in message creation, enhancing overall usability and performance across various components.

Changes

Files	Change Summary
`rocketmq-broker/src/out_api/broker_outer_api.rs`	Modified `invoke_async` to accept optional addresses, improving error handling and flexibility.
`rocketmq-client/examples/producer/simple_producer.rs`	Added logging initialization and enhanced message sending functionality with new `Message` creation methods.
`rocketmq-client/src/base/client_config.rs`	Changed `mq_client_api_timeout` from `u32` to `u64` for improved timeout value management.
`rocketmq-client/src/common.rs`, `rocketmq-client/src/common/client_error_code.rs`	Introduced a new module for client error codes with constant definitions for various errors.
`rocketmq-client/src/consumer/mq_consumer_inner.rs`	Expanded `MQConsumerInner` trait with multiple methods for better message consumption management.
`rocketmq-client/src/error.rs`	Added `RemotingException` variant to `MQClientError` for enhanced error reporting.
`rocketmq-client/src/factory/mq_client_instance.rs`	Updated concurrency handling; added asynchronous methods for topic route info management.
`rocketmq-client/src/hook/check_forbidden_context.rs`, `rocketmq-client/src/hook/send_message_context.rs`	Enhanced context structures for managing message processing and sending operations.
`rocketmq-client/src/implementation.rs`, `rocketmq-client/src/implementation/communication_mode.rs`	Introduced `CommunicationMode` enum for structured communication handling.
`rocketmq-remoting/src/clients.rs`, `rocketmq-remoting/src/clients/rocketmq_default_impl.rs`	Modified `invoke_async` method to use `Option<String>` for address parameters, improving flexibility.
`rocketmq-remoting/src/protocol/body.rs`, `rocketmq-remoting/src/protocol/body/consumer_running_info.rs`	Added new module for consumer running information and defined a structure for better state management.
`rocketmq-remoting/src/protocol/header/client_request_header.rs`	Enhanced `GetRouteInfoRequestHeader` by adding `topic_request_header` for detailed routing information.
`rocketmq-remoting/src/protocol/route/route_data_view.rs`, `rocketmq-remoting/src/protocol/route/topic_route_data.rs`	Changed visibility of fields and functions to improve usability.
`rocketmq-common/src/common/message/message_single.rs`	Added multiple constructors for `Message`, enhancing message creation capabilities.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Producer
    participant Broker

    Client->>Producer: sendMessage(msg)
    Producer-->>Broker: invoke_async(Some(addr), request)
    Broker-->>Producer: sendResult
    Producer-->>Client: return result

Assessment against linked issues

Objective	Addressed	Explanation
Implement Producer send single message (Feature #872)	✅
Improve error handling in async methods	✅
Enhance message structure and creation methods	✅

Poem

🐰 In the code, a change so bright,
Messages now take flight,
Optional addresses, clear and free,
Sending joy through the API!
Hopping fast, no errors to see,
RocketMQ, as smooth as can be! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

mxsm / rocketmq-rust