[ISSUE #879]Implement Produer send single message-2

mxsm commented 1 month ago

Which Issue(s) This PR Fixes(Closes)

Fixes #879

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

New Features
- Introduced support for regular expressions in the project.
- Added a method to retrieve and validate the name server address, enhancing configuration reliability.
- Added a new error variant for excessive remote requests to improve error handling.
- Enhanced message sending functionality with asynchronous support and improved error management.
- New methods for setting unique IDs and accessing broker names in message handling.
Bug Fixes
- Improved error handling by streamlining existing error management.
Refactor
- Reorganized message-related functions into the new MessageAccessor struct to enhance modularity.
- Improved memory efficiency by introducing lifetime parameters in the CheckForbiddenContext struct.
- Enhanced concurrency guarantees in various traits.
Style
- Updated method signatures and organization for improved readability and consistency across the codebase.
Tests
- Added comprehensive tests for new string utility functions to ensure correctness.
Chores
- Updated dependencies and constants for better modularity and maintainability throughout the codebase.

mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent changes enhance the RocketMQ client with improved message handling and error management capabilities. Key modifications include the addition of new methods for managing message contexts, adjustments to existing methods for better handling of optional parameters, and structural improvements to facilitate asynchronous operations. Furthermore, enhancements to error handling and the introduction of utility functions streamline the codebase, ensuring greater flexibility and robustness in producer functionalities.

Changes

Files	Change Summary
`rocketmq-client/Cargo.toml`	Added `regex` crate dependency for regex functionalities.
`rocketmq-client/src/base/client_config.rs`, `rocketmq-client/src/error.rs`, `rocketmq-client/src/hook/`, `rocketmq-client/src/implementation/`, `rocketmq-client/src/producer/*`	Introduced new methods and modified existing ones for better handling of message contexts and error management.
`rocketmq-common/src/common/message.rs`, `rocketmq-common/src/utils/*`	Added new constants and utility functions for improved message handling and string operations.
`rocketmq-remoting/src/protocol/*`	Updated structs and methods for better request handling and response processing.

Sequence Diagram(s)

sequenceDiagram
    participant Producer
    participant MQClientAPIImpl
    participant MessageQueue
    participant Broker

    Producer->>MQClientAPIImpl: send_message(msg)
    MQClientAPIImpl->>MessageQueue: select_one_message_queue(...)
    MessageQueue->>Broker: send_request(...)
    Broker->>MessageQueue: response(...)
    MessageQueue->>MQClientAPIImpl: process_send_response(...)
    MQClientAPIImpl-->>Producer: return send result

Assessment against linked issues

Objective	Addressed	Explanation
Implement Producer send single message-2 (#879)	✅

🐇 In the meadow, we hop and play,
New features bloom like flowers in May.
With messages sent in a swift little dance,
Our code now prances with a merry chance!
Regex and hooks, oh what a delight,
Let’s celebrate changes that feel just right! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 9.22509% with 246 lines in your changes missing coverage. Please review.

Project coverage is 24.82%. Comparing base (2c2f79c) to head (83027ff).

Files	Patch %	Lines
...etmq-common/src/common/message/message_accessor.rs	0.00%	66 Missing :warning:
...mq-client/src/implementation/mq_client_api_impl.rs	0.00%	63 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs	0.00%	41 Missing :warning:
...operation_header/send_message_request_header_v2.rs	0.00%	20 Missing :warning:
rocketmq-client/src/hook/send_message_context.rs	0.00%	12 Missing :warning:
...etmq-common/src/utils/name_server_address_utils.rs	0.00%	10 Missing :warning:
rocketmq-client/src/base/client_config.rs	0.00%	7 Missing :warning:
...mon/src/common/message/message_client_id_setter.rs	0.00%	7 Missing :warning:
rocketmq-remoting/src/protocol/remoting_command.rs	20.00%	4 Missing :warning:
rocketmq-remoting/src/rpc/topic_request_header.rs	0.00%	4 Missing :warning:
... and 7 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #884 +/- ## ========================================== - Coverage 24.89% 24.82% -0.07% ========================================== Files 346 347 +1 Lines 27348 27520 +172 ========================================== + Hits 6808 6833 +25 - Misses 20540 20687 +147 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mxsm / rocketmq-rust