search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUES #892] Support AdminBrokerProcessor query_topics_by_consumer #895

Closed 847850277 closed 1 month ago

847850277 commented 1 month ago

Which Issue(s) This PR Fixes(Closes)

Fixes #892

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago

Walkthrough

The recent code changes enhance the AdminBrokerProcessor to better manage consumer-related topic queries by integrating server configuration. A new method to query topics by consumer group is added, improving offset management. This functionality allows for more dynamic responses to administrative requests, ultimately enhancing the RocketMQ broker's capabilities.

Changes

Files Change Summary
rocketmq-broker/src/broker_runtime.rs Added server_config parameter to AdminBrokerProcessor::new for enhanced configuration.
rocketmq-broker/src/offset/manager/consumer_offset_manager.rs Introduced which_topic_by_consumer method to retrieve topics by consumer group.
rocketmq-broker/src/processor/admin_broker_processor.rs Updated AdminBrokerProcessor to handle server configuration and added request handling for topic queries by consumer.
rocketmq-broker/src/processor/admin_broker_processor/topic_request_handler.rs Added query_topics_by_consumer async function to manage topic queries for specific consumers.
rocketmq-remoting/src/protocol/header.rs Introduced new module query_topics_by_consumer_request_header for handling related requests.
rocketmq-remoting/src/protocol/header/query_topics_by_consumer_request_header.rs Defined QueryTopicsByConsumerRequestHeader struct for consumer topic query requests.

Sequence Diagram(s)

sequenceDiagram
    participant AdminBrokerProcessor
    participant TopicRequestHandler
    participant ConsumerOffsetManager

    AdminBrokerProcessor->>TopicRequestHandler: Request to query topics by consumer
    TopicRequestHandler->>ConsumerOffsetManager: Fetch topics for consumer group
    ConsumerOffsetManager-->>TopicRequestHandler: Return list of topics
    TopicRequestHandler-->>AdminBrokerProcessor: Respond with topics list

Assessment against linked issues

Objective Addressed Explanation
Support AdminBrokerProcessor query_topics_by_consumer (#892) ✅
Enhance AdminBrokerProcessor for server configuration management ✅

🐰 In the fields I hop and play,
New queries bloom, come what may!
Topics found by groups so fine,
Server secrets now align.
Cheers to code that leaps and bounds,
In the broker, joy abounds! 🎉

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 24.38%. Comparing base (9568572) to head (5c3dfef). Report is 1 commits behind head on main.

Files Patch % Lines
.../header/query_topics_by_consumer_request_header.rs 0.00% 22 Missing :warning:
...or/admin_broker_processor/topic_request_handler.rs 0.00% 19 Missing :warning:
...oker/src/offset/manager/consumer_offset_manager.rs 0.00% 11 Missing :warning:
...tmq-broker/src/processor/admin_broker_processor.rs 0.00% 5 Missing :warning:
rocketmq-broker/src/broker_runtime.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #895 +/- ## ========================================== - Coverage 24.43% 24.38% -0.06% ========================================== Files 348 349 +1 Lines 27967 28025 +58 ========================================== Hits 6834 6834 - Misses 21133 21191 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.