search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUE #896]🔥Implement Produer send batch message🚀 #897

Closed mxsm closed 1 month ago

mxsm commented 1 month ago

Which Issue(s) This PR Fixes(Closes)

Fixes #896

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 1 month ago

Walkthrough

The changes enhance the RocketMQ messaging system's efficiency and flexibility, particularly focusing on message handling with the introduction of batch processing capabilities. Modifications to various struct and method signatures allow for greater flexibility in message types, improving performance and usability for producers. New example implementations illustrate these features, thereby enriching the documentation and user experience.

Changes

Files Change Summary
rocketmq-broker/src/...send_message_processor.rs, rocketmq-client/src/...validators.rs, rocketmq-client/src/...check_forbidden_context.rs, rocketmq-client/src/...send_message_context.rs, rocketmq-client/src/...mq_client_api_impl.rs, rocketmq-client/src/...default_mq_producer.rs, rocketmq-client/src/...mq_producer.rs, rocketmq-client/src/...default_mq_producer_impl.rs, rocketmq-common/src/...message.rs, rocketmq-common/src/...message_accessor.rs, rocketmq-common/src/...message_batch.rs, rocketmq-common/src/...message_client_id_setter.rs, rocketmq-common/src/...message_decoder.rs, rocketmq-common/src/...message_single.rs, rocketmq-common/src/...error.rs Various methods and structs updated to support polymorphism via the MessageTrait, enabling better batching and processing of messages. New methods added for encoding, property management, and error handling.
rocketmq-client/Cargo.toml, rocketmq-client/examples/...simple_batch_producer.rs, rocketmq-client/examples/...producer.rs, rocketmq-client/examples/...quickstart/producer.rs New examples illustrating batch and simple producers added, enhancing user guidance and documentation. Cosmetic changes for readability.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Producer
    participant Broker

    User->>Producer: Send Batch Message
    Producer->>Broker: Batch Process Messages
    Broker->>Producer: Acknowledge Receipt
    Producer->>User: Confirm Delivery

Assessment against linked issues

Objective Addressed Explanation
Implement Producer send batch message (Issue #896) ✅

🐰 In the garden of code so bright,
New features bloom in morning light.
Batch messages flow like a stream,
Producers now work as a team!
With traits so dynamic, it’s clear to see,
RocketMQ shines—hoppy as can be! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 1.47601% with 267 lines in your changes missing coverage. Please review.

Project coverage is 24.29%. Comparing base (9568572) to head (12d30df). Report is 2 commits behind head on main.

Files Patch % Lines
...ocketmq-common/src/common/message/message_batch.rs 0.00% 90 Missing :warning:
rocketmq-common/src/common/message.rs 0.00% 82 Missing :warning:
...cketmq-common/src/common/message/message_single.rs 6.97% 40 Missing :warning:
...ketmq-common/src/common/message/message_decoder.rs 0.00% 28 Missing :warning:
...ocketmq-client/src/producer/default_mq_producer.rs 0.00% 19 Missing :warning:
...tmq-broker/src/processor/send_message_processor.rs 0.00% 2 Missing :warning:
...mon/src/common/message/message_client_id_setter.rs 33.33% 2 Missing :warning:
rocketmq-common/src/error.rs 0.00% 2 Missing :warning:
...ocketmq-client/src/hook/check_forbidden_context.rs 0.00% 1 Missing :warning:
rocketmq-client/src/hook/send_message_context.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #897 +/- ## ========================================== - Coverage 24.43% 24.29% -0.14% ========================================== Files 348 348 Lines 27967 28125 +158 ========================================== Hits 6834 6834 - Misses 21133 21291 +158 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.