search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #902]✨Implement Produer send batch message other methods🔥 #904

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #902

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes enhance the RocketMQ client by introducing a new batch messaging producer example, improving message validation, and refining asynchronous operations. Key modifications include the adoption of a more flexible callback mechanism, updates to method signatures for better ownership management, and improved synchronization in client handling. These enhancements collectively bolster performance, usability, and maintainability in message processing.

Changes

Files Change Summary
rocketmq-client/Cargo.toml, rocketmq-client/examples/batch/callback_batch_producer.rs Added a new example for a batch message producer demonstrating callback functionality.
rocketmq-client/src/base/validators.rs, rocketmq-client/src/producer/mq_producer.rs Updated message validation to support generic message types and modified producer methods to accept vectors of messages, enhancing flexibility and usability.
rocketmq-client/src/implementation/mq_client_api_impl.rs, rocketmq-client/src/producer/default_mq_producer.rs Simplified callback handling and improved the asynchronous message sending methods, including enhanced error handling and state management.
rocketmq-client/src/producer/producer_impl/default_mq_producer_impl.rs Introduced new asynchronous message sending methods, improving responsiveness and adding error handling for timeouts and message queue mismatches.
rocketmq-remoting/src/clients/rocketmq_default_impl.rs Enhanced synchronization in client handling by introducing a new ArcSyncClient type and refining method signatures for better thread safety in a concurrent environment.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant BatchProducer
    participant MessageQueue

    User->>BatchProducer: Send batch of messages
    BatchProducer->>MessageQueue: Validate and send messages
    MessageQueue-->>BatchProducer: Acknowledge receipt
    BatchProducer-->>User: Confirm message sent

Assessment against linked issues

Objective Addressed Explanation
Implement producer send batch message other methods (902) ✅

🐇 In the meadow, messages fly,
Batches sent, oh my oh my!
With callbacks dancing through the air,
Asynchronous joy beyond compare!
RocketMQ hops, with grace it flows,
Sending messages where the rabbit goes! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 74 lines in your changes missing coverage. Please review.

Project coverage is 24.25%. Comparing base (1e9ac10) to head (80c2c57). Report is 1 commits behind head on main.

Files Patch % Lines
...etmq-remoting/src/clients/rocketmq_default_impl.rs 0.00% 51 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs 0.00% 10 Missing :warning:
rocketmq-client/src/base/validators.rs 0.00% 8 Missing :warning:
...ocketmq-client/src/producer/default_mq_producer.rs 0.00% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #904 +/- ## ======================================= Coverage 24.24% 24.25% ======================================= Files 350 350 Lines 28183 28173 -10 ======================================= Hits 6834 6834 + Misses 21349 21339 -10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.