search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUE #916]🚀Support producer send rpc message-1 #925

Closed mxsm closed 3 weeks ago

mxsm commented 3 weeks ago

Which Issue(s) This PR Fixes(Closes)

Fixes #916

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 3 weeks ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes involve multiple enhancements across various modules in the rocketmq codebase. Key updates include the introduction of new dependencies for UUID handling, modifications for request-response management within producers, and updates to error handling mechanisms. Additionally, new utility functions for generating correlation IDs have been added, along with structural modifications to support asynchronous operations and improved encapsulation of data.

Changes

File Path Change Summary
Cargo.toml, rocketmq-common/Cargo.toml, rocketmq-remoting/Cargo.toml, rocketmq-client/Cargo.toml Added uuid and once_cell dependencies, with modifications to their configurations for workspace usage.
rocketmq-client/src/factory/mq_client_instance.rs Changed client_id and topic_route_table fields to pub(crate) visibility in MQClientInstance.
rocketmq-client/src/producer.rs Introduced two new modules: request_future_holder and request_response_future with pub(crate) visibility.
rocketmq-client/src/producer/default_mq_producer.rs, rocketmq-client/src/producer/mq_producer.rs Modified request method signatures to accept mutable message ownership for direct modifications.
rocketmq-client/src/producer/producer_impl/default_mq_producer_impl.rs Added asynchronous request and wait_response methods to DefaultMQProducerImpl for enhanced message handling.
rocketmq-client/src/producer/request_callback.rs Introduced a new type alias RequestCallbackFn to support flexible callback functions.
rocketmq-client/src/producer/request_future_holder.rs, rocketmq-client/src/producer/request_response_future.rs Implemented new structs for managing asynchronous request-response futures.
rocketmq-common/src/common/message/message_accessor.rs Added put_property method to MessageAccessor for setting message properties.
rocketmq-common/src/utils.rs, rocketmq-common/src/utils/correlation_id_util.rs Introduced a new module for correlation ID utilities along with a struct for generation.
rocketmq-remoting/src/clients/blocking_client.rs Commented out the invoke_oneway function in BlockingClient, disabling one-way requests.
rocketmq-remoting/src/error.rs Commented out the Elapsed variant in the Error enum, simplifying error handling.

Assessment against linked issues

Objective Addressed Explanation
Support producer send RPC messages (#916) ✅

🐰 A rabbit hops with glee,
New code brings harmony!
UUIDs for every trace,
Async calls now embrace.
A world of messages, all in queue,
Thank you, dear devs, for all you do! 🥕

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 3 weeks ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

mxsm commented 3 weeks ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 85 lines in your changes missing coverage. Please review.

Project coverage is 23.92%. Comparing base (edd3f7c) to head (cf79b3b). Report is 1 commits behind head on main.

Files Patch % Lines
...tmq-client/src/producer/request_response_future.rs 0.00% 55 Missing :warning:
...ketmq-client/src/producer/request_future_holder.rs 0.00% 17 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs 0.00% 7 Missing :warning:
rocketmq-common/src/utils/correlation_id_util.rs 0.00% 3 Missing :warning:
rocketmq-client/src/factory/mq_client_instance.rs 0.00% 2 Missing :warning:
...ocketmq-client/src/producer/default_mq_producer.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #925 +/- ## ========================================== - Coverage 23.98% 23.92% -0.06% ========================================== Files 348 350 +2 Lines 28423 28497 +74 ========================================== + Hits 6816 6817 +1 - Misses 21607 21680 +73 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.