search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #926]🔥Remoting connection implements read-write separation🚀 #932

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #926

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes made to the RocketMQ codebase include enhancements to the handling of remoting requests and responses, with a focus on implementing read-write separation in connections. This involves modifying client and server structures to improve the processing of requests, along with the introduction of new modules and refactoring existing ones to streamline asynchronous operations.

Changes

Files Change Summary
rocketmq-broker/src/out_api/broker_outer_api.rs, rocketmq-client/src/implementation/mq_client_api_impl.rs Updated RocketmqDefaultClient construction to include DefaultRemotingRequestProcessor.
rocketmq-client/src/implementation/client_remoting_processor.rs Enhanced process_request method to handle request codes and log them appropriately.
rocketmq-namesrv/src/bootstrap.rs Changed import paths for request processors and updated client instantiation to include a new processor.
rocketmq-remoting/src/base.rs, rocketmq-remoting/src/base/response_future.rs Introduced response_future module for handling asynchronous responses and added ResponseFuture struct.
rocketmq-remoting/src/clients.rs, rocketmq-remoting/src/clients/client.rs, rocketmq-remoting/src/clients/rocketmq_default_impl.rs Added register_processor method to RemotingClient and refactored Client to use ClientInner.
rocketmq-remoting/src/connection.rs Replaced framed field with separate reader and writer fields for enhanced control over data flow.
rocketmq-remoting/src/runtime/server.rs Updated connection handling methods to use new reader and writer interfaces.
rocketmq-remoting/src/request_processor.rs, rocketmq-remoting/src/request_processor/default_request_processor.rs Introduced default_request_processor module and implemented DefaultRemotingRequestProcessor.

Assessment against linked issues

Objective Addressed Explanation
Implement read-write separation in remoting connections (#926) ✅

🐰 In the land of code, changes hop,
A new way to handle requests, we can't stop!
With processors to guide, and futures anew,
Asynchronous magic, in all that we do!
So let's celebrate, with a joyful cheer,
For RocketMQ's journey is bright and clear! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 165 lines in your changes missing coverage. Please review.

Project coverage is 23.84%. Comparing base (a8a7984) to head (9d0953e). Report is 4 commits behind head on main.

Files Patch % Lines
rocketmq-remoting/src/clients/client.rs 0.00% 113 Missing :warning:
...etmq-remoting/src/clients/rocketmq_default_impl.rs 0.00% 20 Missing :warning:
...src/request_processor/default_request_processor.rs 0.00% 9 Missing :warning:
rocketmq-namesrv/src/bootstrap.rs 0.00% 6 Missing :warning:
rocketmq-remoting/src/connection.rs 0.00% 6 Missing :warning:
rocketmq-broker/src/out_api/broker_outer_api.rs 0.00% 4 Missing :warning:
rocketmq-remoting/src/base/response_future.rs 0.00% 3 Missing :warning:
...mq-client/src/implementation/mq_client_api_impl.rs 0.00% 2 Missing :warning:
rocketmq-remoting/src/runtime/server.rs 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #932 +/- ## ========================================== - Coverage 23.92% 23.84% -0.08% ========================================== Files 350 352 +2 Lines 28497 28593 +96 ========================================== + Hits 6817 6819 +2 - Misses 21680 21774 +94 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.