search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #934]🔥Support producer send rpc message-3🚀 #938

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #934

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 2 months ago

Walkthrough

The changes involve a significant restructuring of the RocketMQ codebase, particularly the relocation of the MessageExt type from the message_single module to a new message_ext module. This adjustment affects various files across both the broker and client components, indicating an effort to enhance the organization and clarity of message handling within the system.

Changes

Files Change Summary
rocketmq-broker/src/hook/*, rocketmq-client/src/base/*, rocketmq-client/src/implementation/*, rocketmq-client/src/producer/*, rocketmq-common/src/common/message.rs, rocketmq-common/src/common/message/message_single.rs, rocketmq-store/src/* The import statement for MessageExt has been changed from message_single to message_ext, indicating a module restructuring.
rocketmq-common/src/common/message/message_ext.rs A new file defining the MessageExt struct has been introduced, enhancing the functionality of the message system.

Assessment against linked issues

Objective Addressed Explanation
Support producer send RPC message-3 (#934) ❌ No specific implementation details for the RPC message sending are present in the changes.

🐰 Hopping through the code with glee,
A new home for messages, can't you see?
From single to ext, they dance and play,
In RocketMQ's garden, they brighten the day!
With traits and types, they leap so high,
A message revolution, oh my, oh my! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 24.70120% with 189 lines in your changes missing coverage. Please review.

Project coverage is 23.46%. Comparing base (090f5eb) to head (4e734eb). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rocketmq-common/src/common/message/message_ext.rs 29.38% 149 Missing :warning:
...cketmq-common/src/common/message/message_single.rs 0.00% 15 Missing :warning:
...tmq-client/src/producer/request_response_future.rs 0.00% 11 Missing :warning:
...ocketmq-common/src/common/message/message_batch.rs 0.00% 9 Missing :warning:
...nt/src/implementation/client_remoting_processor.rs 0.00% 2 Missing :warning:
...mq-common/src/common/message/message_client_ext.rs 0.00% 2 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #938 +/- ## ========================================== - Coverage 23.51% 23.46% -0.06% ========================================== Files 356 358 +2 Lines 28995 29064 +69 ========================================== + Hits 6818 6819 +1 - Misses 22177 22245 +68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.