search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUES #953] Support AdminBrokerProcessor get_consume_stats #954

Closed 847850277 closed 2 weeks ago

847850277 commented 2 weeks ago

Which Issue(s) This PR Fixes(Closes)

Fixes #953

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The changes introduce enhancements to the RocketMQ system, particularly focusing on the AdminBrokerProcessor to support the retrieval of consumption statistics. This includes the addition of new methods and structures for managing and accessing consumer statistics and offsets, improving the overall functionality of the broker's administrative capabilities.

Changes

Files Change Summary
rocketmq-broker/src/broker_runtime.rs Added broker_stats_manager to BrokerRequestProcessor constructor.
rocketmq-broker/src/client/manager/consumer_manager.rs Introduced find_subscription_data_count method to retrieve subscription counts for consumer groups.
rocketmq-broker/src/processor/admin_broker_processor.rs Added BrokerStatsManager to AdminBrokerProcessor and a new request handling case for GetConsumeStats.
rocketmq-broker/src/processor/admin_broker_processor/consumer_request_handler.rs Introduced get_consume_stats method to handle consumption statistics requests.
rocketmq-common/src/common/config.rs Added get_read_queue_nums method to TopicConfig.
rocketmq-common/src/common/stats/stats_item_set.rs Added get_stats_data_in_minute method to StatsItemSet.
rocketmq-remoting/src/protocol/admin.rs Introduced new public modules: consume_stats and offset_wrapper.
rocketmq-remoting/src/protocol/admin/consume_stats.rs Defined ConsumeStats struct for managing consumption statistics.
rocketmq-remoting/src/protocol/admin/offset_wrapper.rs Defined OffsetWrapper struct for managing offset data.
rocketmq-remoting/src/protocol/header.rs Added new request header modules related to consumer statistics.
rocketmq-remoting/src/protocol/header/get_consume_stats_request_header.rs Defined GetConsumeStatsRequestHeader struct for handling stats requests.
rocketmq-store/src/stats/broker_stats_manager.rs Added tps_group_get_nums method for calculating TPS metrics and build_stats_key function.

Assessment against linked issues

Objective Addressed Explanation
Support AdminBrokerProcessor get_consume_stats (##953) ✅

🐰 In a world of queues and stats so bright,
I hop along, my heart feels light.
With new requests and data to share,
Consumption metrics fill the air!
Let's dance and cheer, for changes are here,
In RocketMQ, we spread good cheer! 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
mxsm commented 2 weeks ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 190 lines in your changes missing coverage. Please review.

Project coverage is 22.26%. Comparing base (a62dcd0) to head (5d17130). Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...admin_broker_processor/consumer_request_handler.rs 0.00% 65 Missing :warning:
...rotocol/header/get_consume_stats_request_header.rs 0.00% 34 Missing :warning:
...etmq-remoting/src/protocol/admin/offset_wrapper.rs 0.00% 32 Missing :warning:
...ketmq-remoting/src/protocol/admin/consume_stats.rs 0.00% 27 Missing :warning:
rocketmq-store/src/stats/broker_stats_manager.rs 0.00% 14 Missing :warning:
...etmq-broker/src/client/manager/consumer_manager.rs 0.00% 6 Missing :warning:
...tmq-broker/src/processor/admin_broker_processor.rs 0.00% 5 Missing :warning:
rocketmq-common/src/common/config.rs 0.00% 3 Missing :warning:
rocketmq-common/src/common/stats/stats_item_set.rs 0.00% 3 Missing :warning:
rocketmq-broker/src/broker_runtime.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #954 +/- ## ========================================== - Coverage 22.40% 22.26% -0.14% ========================================== Files 364 367 +3 Lines 29781 29972 +191 ========================================== + Hits 6672 6674 +2 - Misses 23109 23298 +189 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.