search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
538 stars 66 forks source link

[ISSUE #960]🚀Support client consumer message-1🔥 #961

Closed mxsm closed 1 week ago

mxsm commented 1 week ago

Which Issue(s) This PR Fixes(Closes)

Fixes #960

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 1 week ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 1 week ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

The changes introduce a comprehensive set of features and enhancements to the RocketMQ client library, primarily focusing on the implementation of message consumption strategies. New modules and structures are added to facilitate concurrent and orderly message processing, along with configuration capabilities for consumers. Additionally, example implementations and improved organizational structures enhance the usability and maintainability of the codebase.

Changes

Files Change Summary
rocketmq-client/Cargo.toml Added a new example entry for a consumer implementation.
rocketmq-client/examples/quickstart/consumer.rs Introduced a new quickstart example for a message consumer using RocketMQ.
rocketmq-client/src/base/access_channel.rs Added Default trait to AccessChannel enum, allowing a default value.
rocketmq-client/src/consumer.rs Introduced several new public modules to enhance consumer functionality.
rocketmq-client/src/consumer/allocate_message_queue_strategy.rs Defined a new trait for allocating message queues.
rocketmq-client/src/consumer/consumer_impl.rs Added multiple new modules for various message consumption services.
rocketmq-client/src/consumer/consumer_impl/consume_message_concurrently_service.rs Implemented a service for concurrent message consumption.
rocketmq-client/src/consumer/consumer_impl/consume_message_orderly_service.rs Implemented a service for orderly message consumption.
rocketmq-client/src/consumer/default_mq_push_consumer.rs Implemented the main consumer interface and configuration management.
rocketmq-client/src/consumer/default_mq_push_consumer_builder.rs Introduced a builder pattern for constructing DefaultMQPushConsumer instances.
rocketmq-client/src/consumer/listener.rs Added several modules related to message consumption strategies.
rocketmq-client/src/consumer/listener/consume_concurrently_context.rs Defined context management for concurrent message consumption.
rocketmq-client/src/consumer/listener/consume_orderly_context.rs Defined context management for orderly message consumption.
rocketmq-client/src/consumer/listener/consume_concurrently_status.rs Introduced an enum for concurrent consumption statuses.
rocketmq-client/src/consumer/listener/consume_orderly_status.rs Introduced an enum for orderly consumption statuses.

Assessment against linked issues

Objective Addressed Explanation
Support client consumer message-1 (#960) ✅

🐰 "In the fields where messages flow,
New paths for consumers now brightly glow.
With context and status, they leap and play,
In orderly fashion, they find their way.
Hooray for the changes, let the messages sing,
A hop and a skip, oh what joy they bring!" 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 1335 lines in your changes missing coverage. Please review.

Project coverage is 21.32%. Comparing base (a707080) to head (11ce097). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mq-client/src/consumer/default_mq_push_consumer.rs 0.00% 300 Missing :warning:
...t/src/consumer/default_mq_push_consumer_builder.rs 0.00% 235 Missing :warning:
...mer/consumer_impl/default_mq_push_consumer_impl.rs 0.00% 160 Missing :warning:
...nt/src/consumer/consumer_impl/pop_process_queue.rs 0.00% 44 Missing :warning:
...c/protocol/body/consume_message_directly_result.rs 0.00% 38 Missing :warning:
rocketmq-client/src/hook/filter_message_context.rs 0.00% 36 Missing :warning:
...client/src/consumer/consumer_impl/process_queue.rs 0.00% 32 Missing :warning:
rocketmq-client/src/consumer/store/offset_store.rs 0.00% 31 Missing :warning:
rocketmq-client/src/consumer/pull_result.rs 0.00% 30 Missing :warning:
...moting/src/protocol/body/pop_process_queue_info.rs 0.00% 28 Missing :warning:
... and 28 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #961 +/- ## ========================================== - Coverage 22.27% 21.32% -0.95% ========================================== Files 367 398 +31 Lines 29972 31303 +1331 ========================================== Hits 6675 6675 - Misses 23297 24628 +1331 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.