search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #964]🚀Support client consumer message-2🚀 #965

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #964

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request introduces significant changes to the RocketMQ client, focusing on enhancing error handling, restructuring modules, and improving the consumer's message processing capabilities. Key modifications include changing the return type of the allocate method for better error management, introducing new traits and structs for handling message requests, and refining the concurrency model within various components. Additionally, the codebase has been organized to facilitate better modularity and configurability, particularly in consumer behavior and message queue rebalancing.

Changes

Files Change Summary
rocketmq-client/src/consumer/allocate_message_queue_strategy.rs Modified allocate method return type from Vec<MessageQueue> to Result<Vec<MessageQueue>> for improved error handling.
rocketmq-client/src/consumer/consumer_impl.rs Added new modules (message_request, pop_request, re_balance) and a static variable PULL_MAX_IDLE_TIME for improved configuration and organization.
rocketmq-client/src/consumer/consumer_impl/default_mq_push_consumer_impl.rs Refined mq_client_factory type for clarity, updated constructor for rebalance_impl, and changed try_rebalance to an asynchronous function returning Result<bool>.
rocketmq-client/src/consumer/consumer_impl/message_request.rs Removed RebalanceImpl struct and introduced MessageRequest trait for handling message requests flexibly.
rocketmq-client/src/consumer/consumer_impl/pop_process_queue.rs Changed wait_ack_counter from AtomicUsize to Arc<AtomicUsize> for enhanced concurrency and added #[derive(Clone)] for easier cloning.
rocketmq-client/src/consumer/consumer_impl/pop_request.rs Defined PopRequest struct with various fields and methods, implementing the MessageRequest trait.
rocketmq-client/src/consumer/consumer_impl/process_queue.rs Changed tree_map_lock and consume_lock fields to use Arc<RwLock<()>> for improved concurrency.
rocketmq-client/src/consumer/consumer_impl/pull_request.rs Introduced PullRequest struct for managing pull requests, implementing the MessageRequest trait.
rocketmq-client/src/consumer/consumer_impl/re_balance.rs Implemented RebalanceLocal trait for managing queue rebalancing with various methods for handling message queues.
rocketmq-client/src/consumer/consumer_impl/re_balance/rebalance_impl.rs Implemented RebalanceImpl struct for managing message queue rebalancing with methods for subscription management and rebalancing logic.
rocketmq-client/src/consumer/default_mq_push_consumer.rs Simplified allocate_message_queue_strategy type for better usability.
rocketmq-client/src/factory/mq_client_instance.rs Updated MQClientInstance to use a generic type for consumers, enhancing flexibility and performance.
rocketmq-common/src/common/message/message_queue.rs Added Hash, Eq, Ord, and PartialOrd trait implementations to MessageQueue for improved usability in collections.
rocketmq-remoting/src/protocol/route/route_data_view.rs Introduced select_broker_addr method for flexible broker address selection.

Assessment against linked issues

Objective Addressed Explanation
Support client consumer message-2 (#964) ✅

🐰 In the meadow where the bunnies play,
New features hop in, brightening the day!
With queues that dance and messages that sing,
RocketMQ's magic is a wonderful thing!
So let’s cheer for the code, both clever and neat,
For every change brings a tasty treat! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 2.04082% with 240 lines in your changes missing coverage. Please review.

Project coverage is 21.44%. Comparing base (c6def60) to head (67bad86). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/consumer_impl/re_balance/rebalance_push_impl.rs 0.00% 66 Missing :warning:
...q-client/src/consumer/consumer_impl/pop_request.rs 0.00% 57 Missing :warning:
...-client/src/consumer/consumer_impl/pull_request.rs 0.00% 48 Missing :warning:
...ocketmq-common/src/common/message/message_queue.rs 23.80% 16 Missing :warning:
...mer/consumer_impl/default_mq_push_consumer_impl.rs 0.00% 12 Missing :warning:
...onsumer/consumer_impl/re_balance/rebalance_impl.rs 0.00% 12 Missing :warning:
...tmq-remoting/src/protocol/route/route_data_view.rs 0.00% 8 Missing :warning:
...client/src/consumer/consumer_impl/process_queue.rs 0.00% 5 Missing :warning:
rocketmq-client/src/consumer/consumer_impl.rs 0.00% 4 Missing :warning:
...mq-client/src/consumer/consumer_impl/re_balance.rs 0.00% 4 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #965 +/- ## ========================================== + Coverage 21.32% 21.44% +0.12% ========================================== Files 398 402 +4 Lines 31303 31114 -189 ========================================== - Hits 6674 6672 -2 + Misses 24629 24442 -187 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.