search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #966]🚀Support client consumer message-3🚀 #968

Closed mxsm closed 2 months ago

mxsm commented 2 months ago

Which Issue(s) This PR Fixes(Closes)

Fixes #966

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 2 months ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 2 months ago

Walkthrough

This pull request introduces significant enhancements to the RocketMQ client, focusing on the consumer module. Key changes include the implementation of a new concurrent message listener, improved error handling with updated error types, and the introduction of a rebalance strategy module. Additionally, the consumer configuration has been modified for better management, and several methods have been updated to support synchronous operations instead of asynchronous ones. Overall, these changes aim to improve the functionality and maintainability of the consumer implementation.

Changes

Files Change Summary
rocketmq-client/examples/quickstart/consumer.rs Added a new concurrent message listener and updated the main function for message processing.
rocketmq-client/src/base/validators.rs Replaced MQClientException with MQClientErr for error handling in validation methods.
rocketmq-client/src/consumer.rs Introduced a new public module for rebalance strategies.
rocketmq-client/src/consumer/allocate_message_queue_strategy.rs Changed return type of get_name method to &'static str.
rocketmq-client/src/consumer/consumer_impl/default_mq_push_consumer_impl.rs Modified consumer configuration management and introduced new methods for consumer management.
rocketmq-client/src/consumer/default_mq_push_consumer.rs Expanded ConsumerConfig and changed subscribe method to synchronous execution.
rocketmq-client/src/error.rs Renamed error variants for clarity and consistency.
rocketmq-client/src/consumer/rebalance_strategy.rs Added a function for validating consumer IDs within the queue context.
rocketmq-client/src/consumer/rebalance_strategy/allocate_message_queue_averagely.rs Implemented round-robin allocation strategy for message queues.

Sequence Diagram(s)

sequenceDiagram
    participant Consumer
    participant MessageQueue
    participant Listener
    Consumer->>MessageQueue: Subscribe to topic
    MessageQueue-->>Consumer: Acknowledge subscription
    Consumer->>Listener: Register message listener
    Listener->>MessageQueue: Fetch messages
    MessageQueue-->>Listener: Deliver messages
    Listener->>Consumer: Process messages concurrently

Assessment against linked issues

Objective Addressed Explanation
Support client consumer message-3 ( #966 ) ✅

Suggested labels

approved, auto merge

Poem

🐰 In the meadow, messages flow,
With listeners ready, they steal the show.
Errors renamed, clear as can be,
Rabbit hops in, with joy and glee!
Consumer's dance, a synchronized play,
In RocketMQ's world, we leap and sway! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 174 lines in your changes missing coverage. Please review.

Project coverage is 21.24%. Comparing base (c54bd64) to head (3e5a7c8). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mer/consumer_impl/default_mq_push_consumer_impl.rs 0.00% 43 Missing :warning:
...mq-client/src/consumer/default_mq_push_consumer.rs 0.00% 31 Missing :warning:
...lance_strategy/allocate_message_queue_averagely.rs 0.00% 22 Missing :warning:
...er/consumer_impl/re_balance/rebalance_push_impl.rs 0.00% 21 Missing :warning:
rocketmq-client/src/consumer/rebalance_strategy.rs 0.00% 16 Missing :warning:
rocketmq-client/src/base/validators.rs 0.00% 15 Missing :warning:
...t/src/consumer/default_mq_push_consumer_builder.rs 0.00% 12 Missing :warning:
rocketmq-client/src/error.rs 0.00% 8 Missing :warning:
...producer/producer_impl/default_mq_producer_impl.rs 0.00% 3 Missing :warning:
...onsumer/consumer_impl/re_balance/rebalance_impl.rs 0.00% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #968 +/- ## ========================================== - Coverage 21.45% 21.24% -0.22% ========================================== Files 402 404 +2 Lines 31114 31410 +296 ========================================== - Hits 6676 6673 -3 - Misses 24438 24737 +299 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.