search

mxsm / rocketmq-rust

🚀Apache RocketMQ Rust implementation. Faster, safer, and with lower memory usage.
https://docs.rs/rocketmq-rust
Apache License 2.0
608 stars 80 forks source link

[ISSUE #967]🚀 Support client consumer message-4 🚀 #971

Closed mxsm closed 1 month ago

mxsm commented 1 month ago

Which Issue(s) This PR Fixes(Closes)

Fixes #967

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

mxsm commented 1 month ago

🚀Thanks for your contribution🎉. CodeRabbit(AI) will review your code first🔥

coderabbitai[bot] commented 1 month ago

[!WARNING]

Rate limit exceeded

@mxsm has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 8 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between df3c5cacee84e3eb2c9f20040c0cbab4ce715967 and 7182a2c458352b6c1636fb0795928151aef3678b.

Walkthrough

The pull request introduces several enhancements to the RocketMQ client, focusing on improving asynchronous message handling, offset management, and consumer functionalities. Key changes include the addition of new structs and methods for better control over message consumption, alongside modifications to existing methods to support asynchronous operations. The updates aim to refine the overall architecture and responsiveness of the messaging system.

Changes

Files Change Summary
rocketmq-client/examples/quickstart/consumer.rs Added asynchronous handling for Ctrl+C termination in the consumer example.
rocketmq-client/src/consumer/consumer_impl/*.rs Enhanced ConsumeMessageConcurrentlyService and ConsumeMessagePopConcurrentlyService with new fields, constructors, and asynchronous methods for better message handling.
rocketmq-client/src/consumer/consumer_impl/default_mq_push_consumer_impl.rs Converted several methods to asynchronous, improving non-blocking operations for message consumption.
rocketmq-client/src/consumer/store/*.rs Introduced new offset management structures and updated existing methods for mutable access.
rocketmq-remoting/src/protocol/body/*.rs Added new modules and structures for handling client requests and process queue information.
rocketmq-common/src/common/constant/*.rs Introduced new constants and utility functions for date handling.
rocketmq-client/src/implementation/*.rs Added new methods for managing broker interactions and consumer offsets.

Sequence Diagram(s)

sequenceDiagram
    participant Consumer
    participant Broker
    participant MessageQueue

    Consumer->>Broker: Request message
    Broker->>MessageQueue: Fetch message
    MessageQueue-->>Broker: Return message
    Broker-->>Consumer: Deliver message
    Consumer->>Broker: Acknowledge message

Assessment against linked issues

Objective Addressed Explanation
Support client consumer message (Feature #967) ✅

🐇 In the meadow, changes bloom bright,
As messages dance in the soft moonlight.
With new paths for queues, and offsets to steer,
The RocketMQ hops forward, bringing cheer!
Let us celebrate with joy and delight,
For the code is now nimble, ready for flight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 351 lines in your changes missing coverage. Please review.

Project coverage is 21.04%. Comparing base (27debb7) to head (7182a2c). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...client/src/consumer/consumer_impl/process_queue.rs 0.00% 63 Missing :warning:
...er/consumer_impl/re_balance/rebalance_push_impl.rs 0.00% 40 Missing :warning:
...mer/consumer_impl/default_mq_push_consumer_impl.rs 0.00% 35 Missing :warning:
...q-client/src/consumer/store/controllable_offset.rs 0.00% 30 Missing :warning:
...src/consumer/consumer_impl/pull_message_service.rs 0.00% 27 Missing :warning:
...sumer_impl/consume_message_concurrently_service.rs 0.00% 26 Missing :warning:
...ing/src/protocol/body/check_client_request_body.rs 0.00% 25 Missing :warning:
...q-remoting/src/protocol/body/process_queue_info.rs 0.00% 17 Missing :warning:
...ent/src/consumer/consumer_impl/pull_api_wrapper.rs 0.00% 14 Missing :warning:
rocketmq-client/src/factory/mq_client_instance.rs 0.00% 14 Missing :warning:
... and 9 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #971 +/- ## ========================================== - Coverage 21.25% 21.04% -0.21% ========================================== Files 404 408 +4 Lines 31410 31722 +312 ========================================== Hits 6676 6676 - Misses 24734 25046 +312 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.