mxstbr / login-flow

:key: A login/register flow built with React&Redux
https://loginflow.mxstbr.com
MIT License
1.6k stars 215 forks source link

Remove some responsibilities from action #17

Open renancarvalho opened 8 years ago

renancarvalho commented 8 years ago

Hi :)

I think that would be really nice if keep the handling errors in the component itself and remove it from the actions https://github.com/mxstbr/login-flow/blob/master/js/actions/AppActions.js#L195

I'm working on a PR for that, and what I'd like to propose is something like:

The main idea is remove the DOM manipulation from the action.

Does it make sense?

renatorib commented 8 years ago

Surely it makes sense. Actions must not receive any logic.

+1

kopax commented 7 years ago

@renancarvalho +1